ADCIRC v55 #20
Merged
ADCIRC v55 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
|
The build fails on Hera: #19 |
Closed
|
both ADCIRC and NEMS now build successfully; now testing |
|
Great!
…______________________________________________________
Saeed Moghimi, PhD
UCAR/NOAA - NOS Storm Surge Modeling Team Lead
Coastal Marine Modeling Branch, Coast Survey Development Laboratory, Office
of Coast Survey at NOAA National Ocean Service.
Address: 1315 East West Hwy, Room 6607, Silver Spring, Maryland 20910
Phone: (240) 847-8230
Email: [email protected]
Web Page <https://sites.google.com/site/moghimis/home>
The contents of this message are mine personally and do not necessarily
reflect any position of NOAA.
On Fri, Mar 5, 2021 at 3:44 PM Zachary Burnett ***@***.***> wrote:
both ADCIRC and NEMS now build successfully; now testing
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#20 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APZULD7GVFDEDGNZMSPD4W3TCE7DDANCNFSM4YUAWOJA>
.
|
ghost
marked this pull request as ready for review
ghost
mentioned this pull request
ghost
force-pushed
the
feature/adcirc_v55
branch
2 times, most recently
from
8505302
to
4a9fbae
Compare
ghost
force-pushed
the
feature/adcirc_v55
branch
from
4a9fbae
to
a856501
Compare
ghost
mentioned this pull request
Closed
ghost
mentioned this pull request
ghost
requested review from
saeed-moghimi-noaa
and removed request for
saeed-moghimi-noaa
saeed-moghimi-noaa
approved these changes
May 14, 2021
|
@zacharyburnettNOAA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented @pvelissariou1 patch for ADCIRC v55 to the ADCIRC repository and also each submodule