Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing dependency of publish on build job #147

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

SorooshMani-NOAA
Copy link
Collaborator

The publish action needs to be executed when the build action is completed, so that the build packages are available. This dependency is missing in the job definition

The publish action needs to be executed when the build action is completed, so that the build packages are available. This dependency is missing in the job definition
@codecov-commenter
Copy link

Codecov Report

Merging #147 (f8982a7) into main (2656ca7) will increase coverage by 0.42%.
The diff coverage is 91.37%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
+ Coverage   64.39%   64.82%   +0.42%     
==========================================
  Files          35       35              
  Lines        3806     3863      +57     
==========================================
+ Hits         2451     2504      +53     
- Misses       1355     1359       +4     
Impacted Files Coverage Δ
coupledmodeldriver/configure/forcings/__init__.py 100.00% <ø> (ø)
coupledmodeldriver/generate/schism/configure.py 81.48% <ø> (ø)
coupledmodeldriver/generate/schism/base.py 82.73% <50.00%> (-0.80%) ⬇️
coupledmodeldriver/configure/forcings/base.py 83.37% <91.17%> (+0.71%) ⬆️
coupledmodeldriver/client/initialize_schism.py 54.69% <100.00%> (+0.25%) ⬆️
tests/test_generation.py 100.00% <100.00%> (ø)
coupledmodeldriver/configure/base.py 83.33% <0.00%> (+0.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@SorooshMani-NOAA SorooshMani-NOAA merged commit 2ac3c2c into main Dec 1, 2022
@SorooshMani-NOAA SorooshMani-NOAA deleted the bugfix/publish_wf branch December 1, 2022 20:19
@SorooshMani-NOAA SorooshMani-NOAA linked an issue Dec 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI build issue with Python version
2 participants