Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues for using NWM #152

Merged
merged 2 commits into from
Jan 4, 2023
Merged

Fix issues for using NWM #152

merged 2 commits into from
Jan 4, 2023

Conversation

SorooshMani-NOAA
Copy link
Collaborator

  • After adding cache files for NWM, the default object type conversion runs into an issue for PathLike type.
  • The docstring was missing from the NWM configuration class definition

@SorooshMani-NOAA SorooshMani-NOAA merged commit 8435427 into main Jan 4, 2023
@SorooshMani-NOAA SorooshMani-NOAA deleted the bugfix/nwm branch January 4, 2023 17:47
Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.84%. Comparing base (25a599e) to head (da42960).
Report is 61 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   64.84%   64.84%           
=======================================
  Files          35       35           
  Lines        3871     3871           
=======================================
  Hits         2510     2510           
  Misses       1361     1361           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant