Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/plots #146

Merged
merged 8 commits into from
Aug 7, 2024
Merged

Feature/plots #146

merged 8 commits into from
Aug 7, 2024

Conversation

FariborzDaneshvar-NOAA
Copy link
Collaborator

Added reference line and unit to some plots as shown below:

main branch feature/plots
Fig_9_KL_fit image
Fig_10_KL_ensemble15 image
Fig_13_validation_vortex_4_variable_random_2 image
percentiles_50 image

@FariborzDaneshvar-NOAA
Copy link
Collaborator Author

Also updated surrogate.py to plot track on percentiles and probability plots. It would be optional and would not be plotted unless the storm variable is defined by the user. Here are examples of calling these functions with/out tracks:

without storm track (as before)

plot_selected_percentiles(
    node_percentiles=node_percentiles,
    perc_list=percentiles,
    output_directory=output_directory if save_plots else None,
)

plot_selected_probability_fields(
    node_prob_field=node_prob_field,
    level_list=level_m,
    output_directory=output_directory if save_plots else None,
    label_unit_convert_factor=1 / 0.3048,
    label_unit_name='ft',
)

with storm track (optional)

plot_selected_percentiles(
    node_percentiles=node_percentiles,
    perc_list=percentiles,
    output_directory=output_directory if save_plots else None,
    storm=storm_name     ### new ###
)

plot_selected_probability_fields(
    node_prob_field=node_prob_field,
    level_list=level_m,
    output_directory=output_directory if save_plots else None,
    label_unit_convert_factor=1 / 0.3048,
    label_unit_name='ft',
    storm=storm_name     ### new ###
)
without track with track
image image
image image

@SorooshMani-NOAA
Copy link
Collaborator

@FariborzDaneshvar-NOAA please check the rebased changes and let me know if all looks good for merge, thanks!

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 20.68%. Comparing base (43e3f4b) to head (ae00a93).

Files Patch % Lines
ensembleperturbation/plotting/surrogate.py 0.00% 21 Missing ⚠️
...rtainty_quantification/karhunen_loeve_expansion.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #146      +/-   ##
==========================================
- Coverage   20.82%   20.68%   -0.14%     
==========================================
  Files          28       28              
  Lines        3846     3872      +26     
==========================================
  Hits          801      801              
- Misses       3045     3071      +26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SorooshMani-NOAA SorooshMani-NOAA merged commit 2d08625 into main Aug 7, 2024
10 checks passed
@SorooshMani-NOAA SorooshMani-NOAA deleted the feature/plots branch August 7, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants