Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/numpy #150

Merged
merged 11 commits into from
Aug 7, 2024
Merged

Fix/numpy #150

merged 11 commits into from
Aug 7, 2024

Conversation

FariborzDaneshvar-NOAA
Copy link
Collaborator

I replaced round_ with round in surrogate.py and karhunen_loeve_expansion.py to address the following warning:

DeprecationWarning: `round_` is deprecated as of NumPy 1.25.0, and will be removed in NumPy 2.0. Please use `round` instead.

I tested it locally and it worked fine!

@SorooshMani-NOAA would you confirm making this merge?

@SorooshMani-NOAA
Copy link
Collaborator

@FariborzDaneshvar-NOAA here as well, please check the rebased changes and let me know if all looks good for merge, thanks!

@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 20.68%. Comparing base (2d08625) to head (b0a21a6).

Files Patch % Lines
ensembleperturbation/plotting/surrogate.py 0.00% 2 Missing ⚠️
...rtainty_quantification/karhunen_loeve_expansion.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   20.68%   20.68%           
=======================================
  Files          28       28           
  Lines        3872     3872           
=======================================
  Hits          801      801           
  Misses       3071     3071           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SorooshMani-NOAA SorooshMani-NOAA merged commit 7b37332 into main Aug 7, 2024
8 checks passed
@SorooshMani-NOAA SorooshMani-NOAA deleted the fix/numpy branch August 7, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants