Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/gahm converge #159

Merged
merged 11 commits into from
Sep 9, 2024
Merged

Enhance/gahm converge #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a34fc9b
Improve gahm parameter convergence
SorooshMani-NOAA Aug 29, 2024
c2fac15
Styling
SorooshMani-NOAA Aug 29, 2024
20de300
cleaning up GAHM Vr function by adding new variables, reducing number…
WPringle Sep 3, 2024
0dc9c70
Merge branch 'main' into enhance/gahm_converge
WPringle Sep 3, 2024
1e38981
Add convergance test and new testing package dependencies
SorooshMani-NOAA Sep 4, 2024
316f458
Style fix
SorooshMani-NOAA Sep 5, 2024
d9d07aa
Fix timeout multiprocess termination
SorooshMani-NOAA Sep 5, 2024
c7262ac
implementation of true bisection method to improve GAHM convergence. …
WPringle Sep 5, 2024
ed25fd1
reording so that the output parameters are not changed after Vr_test …
WPringle Sep 6, 2024
2216379
updating advisory test files with the convergence changes
WPringle Sep 6, 2024
d3b10cf
updating besttrack test files with the convergence changes
WPringle Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 31 additions & 19 deletions ensembleperturbation/perturbation/atcf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -762,34 +762,46 @@ def find_parameter_from_GAHM_profile(
if B is not None:
# initial guesses when trying to find Bg, phi (and new B)
Bg, phi = self.find_GAHM_parameters(B, Ro_inv)
rfo2 = 0.5 * isotach_rad * f
alpha = Rrat ** Bg
else:
# updates for when trying to find isotach_rad
isotach_rad = Rmax / Rrat
rfo2 = 0.5 * isotach_rad * f
alpha = Rrat ** Bg
alpha_lo = numpy.nan * alpha
alpha_hi = 0 * alpha + 1
beta = Vmax ** 2 * (1 + Ro_inv)
beta[Vmax < Vr] = numpy.nan # no possible solution
Vr_test = 1e6 * MaximumSustainedWindSpeed.unit
tol = 1e-2 * MaximumSustainedWindSpeed.unit
i = 0
itmax = 1000
while any(abs(Vr_test - Vr) > tol):
if B is None:
# updates for when trying to find isotach_rad
isotach_rad = Rmax / Rrat
rfo2 = 0.5 * isotach_rad * f
alpha = Rrat ** Bg
Vr_test = (
numpy.sqrt(
Vmax ** 2 * (1 + Ro_inv) * numpy.exp(phi * (1 - alpha)) * alpha + rfo2 ** 2
)
- rfo2
)
Vr_test[Vr_test < tol] = numpy.nan # no solution
# bi-section method
alpha[Rrat <= 1] *= 0.5 * (1 + (Vr / Vr_test)[Rrat <= 1] ** 2)
alpha[Rrat > 1] *= 0.5 * (1 + (Vr_test / Vr)[Rrat > 1] ** 2)
# updates to desired parameters with current alpha value
if B is not None:
# update to and Bg, phi
# update to Bg, phi
Bg = numpy.log(alpha) / numpy.log(Rrat)
phi = 1 + Ro_inv / (Bg * (1 + Ro_inv))
phi[phi < 1] = 1
else:
# update to Rrat
Rrat = numpy.exp(numpy.log(alpha) / Bg)
Rrat = alpha ** (1 / Bg)
isotach_rad = Rmax / Rrat
rfo2 = 0.5 * isotach_rad * f
# compute Vr using the current set of inputs
expf = numpy.exp(phi * (1 - alpha))
Vr_test = numpy.sqrt(beta * expf * alpha + rfo2 ** 2) - rfo2
# updates to the alphas for bi-section method
alpha_hi[Vr_test > Vr] = alpha[Vr_test > Vr]
alpha_lo[Vr_test < Vr] = alpha[Vr_test < Vr]
# guess new alpha based on error
alpha[Rrat <= 1] *= (Vr / Vr_test)[Rrat <= 1] ** 2
alpha[Rrat > 1] *= (Vr_test / Vr)[Rrat > 1] ** 2
# bi-section method to help convergence
avail = ~numpy.isnan(alpha_lo)
alpha[avail] = 0.5 * (alpha_hi[avail] + alpha_lo[avail])
i += 1
if i == itmax:
raise RuntimeError('GAHM function could not converge')
if B is not None:
return Bg * phi / ((1 + Ro_inv) * numpy.exp(phi - 1)) # B
else:
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ oitnb = { version = '*', optional = true }
pytest = { version = '*', optional = true }
pytest-cov = { version = '*', optional = true }
pytest-xdist = { version = '*', optional = true }
pytest-timeout = { version = '*', optional = true }
wget = { version = '*', optional = true }
m2r2 = { version = '*', optional = true }
sphinx = { version = '*', optional = true }
Expand All @@ -61,7 +62,7 @@ sphinxcontrib-programoutput = { version = '*', optional = true }

[tool.poetry.extras]
plotting = ['cartopy', 'cmocean', 'matplotlib']
testing = ['pytest', 'pytest-cov', 'pytest-socket', 'pytest-xdist', 'wget']
testing = ['pytest', 'pytest-cov', 'pytest-socket', 'pytest-xdist', 'pytest-timeout', 'wget']
development = ['isort', 'oitnb']
documentation = ['dunamai', 'm2r2', 'sphinx', 'sphinx-rtd-theme', 'sphinxcontrib-programoutput', 'sphinxcontrib-bibtex', 'cartopy', 'cmocean', 'matplotlib']
adcirc = ['adcircpy']
Expand Down
4 changes: 2 additions & 2 deletions tests/data/reference/test_existing_advisory/vortex_4_variable_korobov_3.22
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
AL, 06, 2018091218, , OFCL, 0, 305N, 719W, 108, 945, HU, 34, NEQ, 160, 132, 94, 132, 1013, 0, 14,,, ,, , 315, 8, , 1
AL, 06, 2018091218, , OFCL, 0, 305N, 719W, 108, 945, HU, 50, NEQ, 93, 74, 56, 74, 1013, 0, 14,,, ,, , 315, 8, , 1
AL, 06, 2018091218, , OFCL, 0, 305N, 719W, 108, 945, HU, 50, NEQ, 93, 75, 56, 75, 1013, 0, 14,,, ,, , 315, 8, , 1
AL, 06, 2018091218, , OFCL, 0, 305N, 719W, 108, 945, HU, 64, NEQ, 55, 55, 37, 55, 1013, 0, 14,,, ,, , 315, 8, , 1
AL, 06, 2018091218, , OFCL, 3, 310N, 726W, 102, 953, HU, 34, NEQ, 155, 126, 87, 123, 1013, 0, 14,,, ,, , 315, 8, , 2
AL, 06, 2018091218, , OFCL, 3, 310N, 726W, 102, 953, HU, 50, NEQ, 89, 70, 51, 69, 1013, 0, 14,,, ,, , 315, 8, , 2
AL, 06, 2018091218, , OFCL, 3, 310N, 726W, 102, 953, HU, 64, NEQ, 52, 52, 33, 50, 1013, 0, 14,,, ,, , 315, 8, , 2
AL, 06, 2018091218, , OFCL, 12, 323N, 742W, 105, 951, HU, 34, NEQ, 137, 110, 75, 108, 1013, 0, 12,,, ,, , 313, 7, , 3
AL, 06, 2018091218, , OFCL, 12, 323N, 742W, 105, 951, HU, 50, NEQ, 77, 60, 44, 59, 1013, 0, 12,,, ,, , 313, 7, , 3
AL, 06, 2018091218, , OFCL, 12, 323N, 742W, 105, 951, HU, 64, NEQ, 44, 44, 29, 43, 1013, 0, 12,,, ,, , 313, 7, , 3
AL, 06, 2018091218, , OFCL, 12, 323N, 742W, 105, 951, HU, 64, NEQ, 44, 44, 28, 43, 1013, 0, 12,,, ,, , 313, 7, , 3
AL, 06, 2018091218, , OFCL, 24, 337N, 762W, 102, 954, HU, 34, NEQ, 114, 91, 61, 89, 1013, 0, 9,,, ,, , 310, 6, , 4
AL, 06, 2018091218, , OFCL, 24, 337N, 762W, 102, 954, HU, 50, NEQ, 62, 48, 34, 47, 1013, 0, 9,,, ,, , 310, 6, , 4
AL, 06, 2018091218, , OFCL, 24, 337N, 762W, 102, 954, HU, 64, NEQ, 34, 34, 22, 33, 1013, 0, 9,,, ,, , 310, 6, , 4
Expand Down
2 changes: 1 addition & 1 deletion tests/data/reference/test_existing_advisory/vortex_4_variable_korobov_6.22
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ AL, 06, 2018091218, , OFCL, 48, 336N, 785W, 104, 951, HU, 34, NEQ, 169,
AL, 06, 2018091218, , OFCL, 48, 336N, 785W, 104, 951, HU, 50, NEQ, 99, 78, 57, 57, 1013, 0, 13,,, ,, , 254, 2, , 6
AL, 06, 2018091218, , OFCL, 48, 336N, 785W, 104, 951, HU, 64, NEQ, 59, 59, 38, 38, 1013, 0, 13,,, ,, , 254, 2, , 6
AL, 06, 2018091218, , OFCL, 72, 335N, 802W, 74, 982, HU, 34, NEQ, 172, 138, 64, 64, 1013, 0, 12,,, ,, , 266, 2, , 7
AL, 06, 2018091218, , OFCL, 72, 335N, 802W, 74, 982, HU, 50, NEQ, 82, 81, 37, 37, 1013, 0, 12,,, ,, , 266, 2, , 7
AL, 06, 2018091218, , OFCL, 72, 335N, 802W, 74, 982, HU, 50, NEQ, 82, 82, 37, 37, 1013, 0, 12,,, ,, , 266, 2, , 7
AL, 06, 2018091218, , OFCL, 96, 346N, 829W, 34, 1007, TD, 34, NEQ, 0, 0, 0, 0, 1013, 0, 10,,, ,, , 296, 3, , 8
AL, 06, 2018091218, , OFCL, 120, 364N, 850W, 24, 1010, LO, 34, NEQ, 0, 0, 0, 0, 1013, 0, 13,,, ,, , 316, 3, , 9
6 changes: 3 additions & 3 deletions tests/data/reference/test_existing_advisory/vortex_4_variable_korobov_8.22
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ AL, 06, 2018091218, , OFCL, 12, 320N, 742W, 118, 931, HU, 64, NEQ, 86,
AL, 06, 2018091218, , OFCL, 24, 332N, 760W, 122, 925, HU, 34, NEQ, 239, 200, 147, 203, 1013, 0, 21,,, ,, , 309, 5, , 4
AL, 06, 2018091218, , OFCL, 24, 332N, 760W, 122, 925, HU, 50, NEQ, 150, 121, 93, 123, 1013, 0, 21,,, ,, , 309, 5, , 4
AL, 06, 2018091218, , OFCL, 24, 332N, 760W, 122, 925, HU, 64, NEQ, 94, 95, 64, 97, 1013, 0, 21,,, ,, , 309, 5, , 4
AL, 06, 2018091218, , OFCL, 36, 336N, 771W, 119, 930, HU, 34, NEQ, 269, 226, 168, 229, 1013, 0, 25,,, ,, , 293, 3, , 5
AL, 06, 2018091218, , OFCL, 36, 336N, 771W, 119, 930, HU, 34, NEQ, 269, 227, 168, 229, 1013, 0, 25,,, ,, , 293, 3, , 5
AL, 06, 2018091218, , OFCL, 36, 336N, 771W, 119, 930, HU, 50, NEQ, 172, 140, 108, 142, 1013, 0, 25,,, ,, , 293, 3, , 5
AL, 06, 2018091218, , OFCL, 36, 336N, 771W, 119, 930, HU, 64, NEQ, 111, 112, 76, 114, 1013, 0, 25,,, ,, , 293, 3, , 5
AL, 06, 2018091218, , OFCL, 48, 336N, 776W, 113, 937, HU, 34, NEQ, 282, 238, 179, 210, 1013, 0, 27,,, ,, , 273, 1, , 6
AL, 06, 2018091218, , OFCL, 48, 336N, 776W, 113, 937, HU, 50, NEQ, 182, 149, 116, 115, 1013, 0, 27,,, ,, , 273, 1, , 6
AL, 06, 2018091218, , OFCL, 48, 336N, 776W, 113, 937, HU, 64, NEQ, 119, 120, 82, 81, 1013, 0, 27,,, ,, , 273, 1, , 6
AL, 06, 2018091218, , OFCL, 48, 336N, 776W, 113, 937, HU, 64, NEQ, 119, 121, 82, 81, 1013, 0, 27,,, ,, , 273, 1, , 6
AL, 06, 2018091218, , OFCL, 72, 330N, 789W, 84, 972, HU, 34, NEQ, 299, 249, 129, 128, 1013, 0, 24,,, ,, , 243, 2, , 7
AL, 06, 2018091218, , OFCL, 72, 330N, 789W, 84, 972, HU, 50, NEQ, 169, 170, 84, 83, 1013, 0, 24,,, ,, , 243, 2, , 7
AL, 06, 2018091218, , OFCL, 72, 330N, 789W, 84, 972, HU, 50, NEQ, 169, 171, 84, 83, 1013, 0, 24,,, ,, , 243, 2, , 7
AL, 06, 2018091218, , OFCL, 96, 330N, 819W, 44, 1002, TD, 34, NEQ, 48, 44, 35, 39, 1013, 0, 26,,, ,, , 271, 3, , 8
AL, 06, 2018091218, , OFCL, 120, 344N, 843W, 34, 1006, LO, 34, NEQ, 0, 0, 0, 0, 1013, 0, 29,,, ,, , 305, 3, , 9
4 changes: 2 additions & 2 deletions tests/data/reference/test_existing_advisory/vortex_4_variable_korobov_9.22
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
AL, 06, 2018091218, , OFCL, 0, 304N, 720W, 114, 937, HU, 34, NEQ, 186, 154, 110, 154, 1013, 0, 16,,, ,, , 311, 8, , 1
AL, 06, 2018091218, , OFCL, 0, 304N, 720W, 114, 937, HU, 34, NEQ, 186, 153, 110, 153, 1013, 0, 16,,, ,, , 311, 8, , 1
AL, 06, 2018091218, , OFCL, 0, 304N, 720W, 114, 937, HU, 50, NEQ, 111, 89, 66, 89, 1013, 0, 16,,, ,, , 311, 8, , 1
AL, 06, 2018091218, , OFCL, 0, 304N, 720W, 114, 937, HU, 64, NEQ, 67, 67, 44, 67, 1013, 0, 16,,, ,, , 311, 8, , 1
AL, 06, 2018091218, , OFCL, 3, 309N, 726W, 112, 940, HU, 34, NEQ, 191, 157, 113, 158, 1013, 0, 16,,, ,, , 311, 8, , 2
Expand All @@ -17,6 +17,6 @@ AL, 06, 2018091218, , OFCL, 48, 331N, 782W, 120, 928, HU, 34, NEQ, 236,
AL, 06, 2018091218, , OFCL, 48, 331N, 782W, 120, 928, HU, 50, NEQ, 147, 116, 86, 86, 1013, 0, 17,,, ,, , 242, 1, , 6
AL, 06, 2018091218, , OFCL, 48, 331N, 782W, 120, 928, HU, 64, NEQ, 92, 93, 59, 58, 1013, 0, 17,,, ,, , 242, 1, , 6
AL, 06, 2018091218, , OFCL, 72, 325N, 797W, 92, 965, HU, 34, NEQ, 281, 227, 104, 103, 1013, 0, 15,,, ,, , 247, 2, , 7
AL, 06, 2018091218, , OFCL, 72, 325N, 797W, 92, 965, HU, 50, NEQ, 156, 158, 66, 65, 1013, 0, 15,,, ,, , 247, 2, , 7
AL, 06, 2018091218, , OFCL, 72, 325N, 797W, 92, 965, HU, 50, NEQ, 155, 158, 66, 65, 1013, 0, 15,,, ,, , 247, 2, , 7
AL, 06, 2018091218, , OFCL, 96, 330N, 834W, 52, 998, TD, 34, NEQ, 37, 34, 27, 29, 1013, 0, 14,,, ,, , 280, 4, , 8
AL, 06, 2018091218, , OFCL, 120, 347N, 862W, 42, 1003, LO, 34, NEQ, 31, 27, 0, 22, 1013, 0, 17,,, ,, , 306, 4, , 9
10 changes: 5 additions & 5 deletions tests/data/reference/test_monovariate_besttrack_ensemble/vortex_1_variable_perturbation_1.22
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ AL, 06, 2018091312, , BEST, 0, 331N, 751W, 98, 950, HU, 34, NEQ, 177,
AL, 06, 2018091312, , BEST, 0, 331N, 751W, 98, 950, HU, 50, NEQ, 105, 94, 85, 84, 1011, 200, 20, 115, 0, L, 0, , 313, 5, FLORENCE, 11
AL, 06, 2018091312, , BEST, 0, 331N, 751W, 98, 950, HU, 64, NEQ, 74, 64, 54, 64, 1011, 200, 20, 115, 0, L, 0, , 313, 5, FLORENCE, 11
AL, 06, 2018091318, , BEST, 0, 336N, 760W, 93, 949, HU, 34, NEQ, 178, 157, 126, 147, 1011, 200, 20, 110, 0, L, 0, , 304, 5, FLORENCE, 12
AL, 06, 2018091318, , BEST, 0, 336N, 760W, 93, 949, HU, 50, NEQ, 106, 95, 85, 85, 1011, 200, 20, 110, 0, L, 0, , 304, 5, FLORENCE, 12
AL, 06, 2018091318, , BEST, 0, 336N, 760W, 93, 949, HU, 50, NEQ, 105, 95, 85, 85, 1011, 200, 20, 110, 0, L, 0, , 304, 5, FLORENCE, 12
AL, 06, 2018091318, , BEST, 0, 336N, 760W, 93, 949, HU, 64, NEQ, 75, 64, 54, 65, 1011, 200, 20, 110, 0, L, 0, , 304, 5, FLORENCE, 12
AL, 06, 2018091400, , BEST, 0, 340N, 765W, 93, 948, HU, 34, NEQ, 178, 157, 136, 104, 1012, 200, 20, 105, 0, L, 0, , 314, 3, FLORENCE, 13
AL, 06, 2018091400, , BEST, 0, 340N, 765W, 93, 948, HU, 50, NEQ, 105, 84, 85, 74, 1012, 200, 20, 105, 0, L, 0, , 314, 3, FLORENCE, 13
Expand Down Expand Up @@ -60,11 +60,11 @@ AL, 06, 2018091518, , BEST, 0, 336N, 798W, 53, 995, TS, 50, NEQ, 129,
AL, 06, 2018091600, , BEST, 0, 336N, 802W, 47, 997, TS, 34, NEQ, 132, 132, 163, 167, 1013, 240, 110, 50, 0, L, 0, , 270, 2, FLORENCE, 22
AL, 06, 2018091606, , BEST, 0, 336N, 808W, 42, 998, TS, 34, NEQ, 134, 135, 136, 145, 1013, 260, 110, 40, 0, L, 0, , 270, 3, FLORENCE, 23
AL, 06, 2018091612, , BEST, 0, 336N, 815W, 37, 1001, TS, 34, NEQ, 169, 154, 0, 0, 1013, 280, 140, 40, 0, L, 0, , 270, 3, FLORENCE, 24
AL, 06, 2018091618, , BEST, 0, 341N, 821W, 32, 1005, TD, 0, , 0, 0, 0, 0, 1013, 300, 140, 40, 0, L, 0, , 315, 4, FLORENCE, 25
AL, 06, 2018091700, , BEST, 0, 350N, 822W, 27, 1006, TD, 0, , 0, 0, 432, 0, 1013, 320, 150, 35, 0, L, 0, , 355, 5, FLORENCE, 26
AL, 06, 2018091618, , BEST, 0, 341N, 821W, 32, 1005, TD, 0, , 0, 0, 435, 560, 1013, 300, 140, 40, 0, L, 0, , 315, 4, FLORENCE, 25
AL, 06, 2018091700, , BEST, 0, 350N, 822W, 27, 1006, TD, 0, , 0, 0, 432, 581, 1013, 320, 150, 35, 0, L, 0, , 355, 5, FLORENCE, 26
AL, 06, 2018091706, , BEST, 0, 364N, 826W, 27, 1007, TD, 0, , 0, 0, 343, 480, 1013, 340, 160, 35, 0, L, 0, , 347, 7, FLORENCE, 27
AL, 06, 2018091712, , BEST, 0, 378N, 822W, 27, 1007, EX, 0, , 0, 0, 338, 471, 1013, 360, 160, 30, 0, L, 0, , 13, 7, FLORENCE, 28
AL, 06, 2018091718, , BEST, 0, 388N, 820W, 27, 1007, EX, 0, , 0, 0, 367, 0, 1013, 360, 160, 30, 0, L, 0, , 9, 5, FLORENCE, 29
AL, 06, 2018091712, , BEST, 0, 378N, 822W, 27, 1007, EX, 0, , 0, 0, 339, 471, 1013, 360, 160, 30, 0, L, 0, , 13, 7, FLORENCE, 28
AL, 06, 2018091718, , BEST, 0, 388N, 820W, 27, 1007, EX, 0, , 0, 0, 367, 475, 1013, 360, 160, 30, 0, L, 0, , 9, 5, FLORENCE, 29
AL, 06, 2018091800, , BEST, 0, 395N, 805W, 27, 1007, EX, 0, , 0, 0, 339, 462, 1013, 360, 160, 0, 0, , 0, , 59, 7, FLORENCE, 30
AL, 06, 2018091806, , BEST, 0, 413N, 768W, 27, 1007, EX, 0, , 0, 0, 0, 316, 1013, 360, 170, 0, 0, , 0, , 56, 17, FLORENCE, 31
AL, 06, 2018091812, , BEST, 0, 422N, 733W, 27, 1006, EX, 34, NEQ, 0, 0, 0, 0, 1013, 360, 180, 30, 0, L, 0, , 70, 14, FLORENCE, 32
8 changes: 4 additions & 4 deletions tests/data/reference/test_monovariate_besttrack_ensemble/vortex_1_variable_perturbation_2.22
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ AL, 06, 2018091318, , BEST, 0, 336N, 760W, 87, 957, HU, 64, NEQ, 65,
AL, 06, 2018091400, , BEST, 0, 340N, 765W, 87, 956, HU, 34, NEQ, 162, 143, 124, 96, 1012, 200, 20, 105, 0, L, 0, , 314, 3, FLORENCE, 13
AL, 06, 2018091400, , BEST, 0, 340N, 765W, 87, 956, HU, 50, NEQ, 95, 76, 75, 66, 1012, 200, 20, 105, 0, L, 0, , 314, 3, FLORENCE, 13
AL, 06, 2018091400, , BEST, 0, 340N, 765W, 87, 956, HU, 64, NEQ, 65, 56, 46, 47, 1012, 200, 20, 105, 0, L, 0, , 314, 3, FLORENCE, 13
AL, 06, 2018091406, , BEST, 0, 342N, 772W, 82, 956, HU, 34, NEQ, 162, 143, 123, 95, 1012, 200, 20, 100, 0, L, 0, , 289, 3, FLORENCE, 14
AL, 06, 2018091406, , BEST, 0, 342N, 772W, 82, 956, HU, 34, NEQ, 161, 143, 123, 95, 1012, 200, 20, 100, 0, L, 0, , 289, 3, FLORENCE, 14
AL, 06, 2018091406, , BEST, 0, 342N, 772W, 82, 956, HU, 50, NEQ, 94, 75, 75, 66, 1012, 200, 20, 100, 0, L, 0, , 289, 3, FLORENCE, 14
AL, 06, 2018091406, , BEST, 0, 342N, 772W, 82, 956, HU, 64, NEQ, 64, 55, 53, 46, 1012, 200, 20, 100, 0, L, 0, , 289, 3, FLORENCE, 14
AL, 06, 2018091411, 15, BEST, 0, 342N, 778W, 77, 960, HU, 34, NEQ, 161, 142, 132, 86, 1012, 200, 25, 0, 0, , 0, , 270, 3, FLORENCE, 15
Expand All @@ -58,11 +58,11 @@ AL, 06, 2018091518, , BEST, 0, 336N, 798W, 47, 999, TS, 34, NEQ, 136,
AL, 06, 2018091600, , BEST, 0, 336N, 802W, 43, 999, TS, 34, NEQ, 128, 127, 148, 152, 1013, 240, 110, 50, 0, L, 0, , 270, 2, FLORENCE, 22
AL, 06, 2018091606, , BEST, 0, 336N, 808W, 38, 1000, TS, 34, NEQ, 126, 124, 0, 0, 1013, 260, 110, 40, 0, L, 0, , 270, 3, FLORENCE, 23
AL, 06, 2018091612, , BEST, 0, 336N, 815W, 33, 1003, TS, 34, NEQ, 0, 0, 0, 0, 1013, 280, 140, 40, 0, L, 0, , 270, 3, FLORENCE, 24
AL, 06, 2018091618, , BEST, 0, 341N, 821W, 28, 1007, TD, 0, , 0, 0, 0, 0, 1013, 300, 140, 40, 0, L, 0, , 315, 4, FLORENCE, 25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WPringle thanks for checking, just to double check, can you explain why these values changes from 0 to some large values? Is the new approach avoiding some nan values that we previously used to get?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SorooshMani-NOAA Yes, the old approach didn't actually converge in some cases so would just get a 0. Now it should always converge to something if it is possible to.

AL, 06, 2018091700, , BEST, 0, 350N, 822W, 23, 1008, TD, 0, , 0, 0, 361, 0, 1013, 320, 150, 35, 0, L, 0, , 355, 5, FLORENCE, 26
AL, 06, 2018091618, , BEST, 0, 341N, 821W, 28, 1007, TD, 0, , 0, 0, 383, 486, 1013, 300, 140, 40, 0, L, 0, , 315, 4, FLORENCE, 25
AL, 06, 2018091700, , BEST, 0, 350N, 822W, 23, 1008, TD, 0, , 0, 0, 361, 476, 1013, 320, 150, 35, 0, L, 0, , 355, 5, FLORENCE, 26
AL, 06, 2018091706, , BEST, 0, 364N, 826W, 23, 1009, TD, 0, , 0, 0, 279, 383, 1013, 340, 160, 35, 0, L, 0, , 347, 7, FLORENCE, 27
AL, 06, 2018091712, , BEST, 0, 378N, 822W, 23, 1009, EX, 0, , 0, 0, 276, 376, 1013, 360, 160, 30, 0, L, 0, , 13, 7, FLORENCE, 28
AL, 06, 2018091718, , BEST, 0, 388N, 820W, 23, 1009, EX, 0, , 0, 0, 312, 0, 1013, 360, 160, 30, 0, L, 0, , 9, 5, FLORENCE, 29
AL, 06, 2018091718, , BEST, 0, 388N, 820W, 23, 1009, EX, 0, , 0, 0, 312, 397, 1013, 360, 160, 30, 0, L, 0, , 9, 5, FLORENCE, 29
AL, 06, 2018091800, , BEST, 0, 395N, 805W, 23, 1009, EX, 0, , 0, 0, 279, 373, 1013, 360, 160, 0, 0, , 0, , 59, 7, FLORENCE, 30
AL, 06, 2018091806, , BEST, 0, 413N, 768W, 23, 1007, EX, 0, , 0, 0, 0, 316, 1013, 360, 170, 0, 0, , 0, , 56, 17, FLORENCE, 31
AL, 06, 2018091812, , BEST, 0, 422N, 733W, 23, 1006, EX, 34, NEQ, 0, 0, 0, 0, 1013, 360, 180, 30, 0, L, 0, , 70, 14, FLORENCE, 32
Loading