Feature/atcf class #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changing BestTrack/besttrack to Vortex/vortex for more general terminology - Setting allowable record_types to either 'BEST' or 'OFCL' (could be extended in future) - 'OFCL' corresponds to official NHC advisory. In these cases the actual datetime needs to be computed as the base datetime plus the validation time (while 'BEST' base datetimes in the column are correct) - When getting historical a-deck many different advisories are present in the one file. Use start_date to filter the one that you want where start_date == initialization time (the base datetime in the column)
…n downloading from archive
- Currently a few record_types are allowed for a-deck based on those that have enough columns to include e.g., the background pressure column, e.g., HWRF, HMON, OFCL - Note only 'BEST' is allowed for b-deck
|
@WPringle would you mind adding me as a collaborator to your repo? |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improving the atcf class to handle a-deck (forecast advisories) as well as b-deck (best track).
requested_record_typeoptional input)start_dateto determine which advisory to get (which initialization time)BestTrackForcingand BestTrack usage toVortexForcing. Open to suggestions for better wording here.