Rework embedding table to not use complex numbers #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsuderman
force-pushed
the
rework_rotary
branch
2 times, most recently
from
1e232ba
to
3ccf4fc
Compare
Interleaved writes are problematic for fusions. Reworked the embedding update to better work with non-complex writes. This should better support fusions.
rsuderman
force-pushed
the
rework_rotary
branch
from
3ccf4fc
to
c1f0cfe
Compare
archana-ramalingam
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interleaved writes are problematic for fusions. Reworked the embedding update to better work with non-complex writes. This should better support fusions.