Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect "weird" TensorMetadata and warn or provide special case hooks #140

Closed
Tracked by #139
stellaraccident opened this issue Oct 31, 2023 · 0 comments · Fixed by #162
Closed
Tracked by #139

Detect "weird" TensorMetadata and warn or provide special case hooks #140

stellaraccident opened this issue Oct 31, 2023 · 0 comments · Fixed by #162
Milestone
Path to V1

Comments

@stellaraccident
Copy link
Contributor

No description provided.

@stellaraccident stellaraccident mentioned this issue Oct 31, 2023
Closed
5 tasks
@stellaraccident stellaraccident added this to the Path to V1 milestone Oct 31, 2023
@saienduri saienduri mentioned this issue Nov 9, 2023
Merged
saienduri added a commit that referenced this issue Nov 9, 2023
@saienduri
Dynamo fx completeness (#162)
a92d64f 
This PR takes care of
#139.

For the weird tensor meta data, we should only throw error if quantized.
If we start looking at other things like stride, memory_format, etc. the
pytest fails.

For the TODO where we wanted to throw a KeyError, we already check if
parameter.name in node.kwargs in the if statement above, so we won't run
into an invalid key.

Other issues that were part of this importer completeness task have been
addressed and documented.

Fixes #139 
Fixes #140 
Fixes #141 
Fixes #142 
Fixes #143 
Fixes #144
IanNod pushed a commit that referenced this issue Nov 9, 2023
@saienduri @IanNod
Dynamo fx completeness (#162)
48a855f 
This PR takes care of
#139.

For the weird tensor meta data, we should only throw error if quantized.
If we start looking at other things like stride, memory_format, etc. the
pytest fails.

For the TODO where we wanted to throw a KeyError, we already check if
parameter.name in node.kwargs in the if statement above, so we won't run
into an invalid key.

Other issues that were part of this importer completeness task have been
addressed and documented.

Fixes #139 
Fixes #140 
Fixes #141 
Fixes #142 
Fixes #143 
Fixes #144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Path to V1
Development

Successfully merging a pull request may close this issue.

Dynamo fx completeness nod-ai/SHARK-Turbine
1 participant
@stellaraccident