Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing CI error by setting sequelize-typescript to version 2.1.2 #61

Merged
merged 1 commit into from
Apr 28, 2022
Merged

Conversation

samstefan
Copy link
Contributor

This pull request fixes #60

sequelize-typescript 2.1.3 is not compatible with sequelize 6.10.0 due to this change sequelize/sequelize-typescript#1202

sequelize-typescript 2.1.3 was being installed in the CI due to the --no-lockfile flag passed to yarn.

2.1.3 is not compatible with sequelize 6.10.0 due to this change sequelize/sequelize-typescript#1202
@casbin-bot
Copy link

@Gabriel-403 @Zxilly @kingiw @nodece please review

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2234879957

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 86.207%

Totals Coverage Status
Change from base Build 2234412466: 0.0%
Covered Lines: 100
Relevant Lines: 108

💛 - Coveralls

@hsluoyz hsluoyz changed the title Bug: Fixing sequelize-typescript to version 2.1.2 fix: fix CI error by fixing sequelize-typescript to version 2.1.2 Apr 28, 2022
@hsluoyz hsluoyz merged commit 9c48749 into node-casbin:master Apr 28, 2022
@samstefan
Copy link
Contributor Author

@hsluoyz Do you know when this change will be published to NPM?

@samstefan samstefan changed the title fix: fix CI error by fixing sequelize-typescript to version 2.1.2 fix: fixing CI error by setting sequelize-typescript to version 2.1.2 Apr 28, 2022
@hsluoyz
Copy link
Member

hsluoyz commented Apr 28, 2022

@samstefan it is supposed to release new version, can you check why it failed?

semantic-release:
needs: [finish, build]
runs-on: ubuntu-latest
services:
mysql:
image: mysql:latest
ports:
- 3306:3306
env:
MYSQL_ALLOW_EMPTY_PASSWORD: yes
options: --health-cmd="mysqladmin ping" --health-interval=5s --health-timeout=2s --health-retries=3
steps:
- uses: actions/checkout@v2
- name: Run semantic-release
if: github.repository == 'node-casbin/sequelize-adapter' && github.event_name == 'push'
run: |
yarn install --no-lockfile
mysql --host 127.0.0.1 --port 3306 -uroot -p -e "CREATE DATABASE casbin"
yarn run prepack
yarn run release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI error: error TS2307: Cannot find module 'sequelize/types/hooks' or its corresponding type declarations.
4 participants