Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug: internal, implementation, error #433

Closed
jamkaramol opened this issue Jul 4, 2017 · 9 comments
Closed

Debug: internal, implementation, error #433

jamkaramol opened this issue Jul 4, 2017 · 9 comments

Comments

@jamkaramol
Copy link

TypeError: Uncaught error: this._parser.write is not a function
How to fix this error ???

@tiagofabre
Copy link

I also have this error :/

@xarguments
Copy link
Collaborator

xarguments commented Jun 24, 2018

@jamkaramol, @tiagofabre, could you please provide more info? When it happens?
Which version of lib you use, NodeJS/NPM version, etc?

Is this related to #419

@tunnckoCore
Copy link
Member

Ha, definitely sounds like a Hapi. Lets close and mark as duplicate this one?

@shriram9494
Copy link

Debug: internal, implementation, error
TypeError: Uncaught error: _knex2.default.raw(...).leftJoin is not a function

@xarguments
Copy link
Collaborator

@shriram9494, could you please provide more info? When it happens? What code you used?
If it's repeatable we can reopen the issue.

@MaxFichtelmann
Copy link
Collaborator

MaxFichtelmann commented Apr 9, 2021

I ran into this issue recently (with version 1.2.2).

The analyzed cause was a misconfigured reverse proxy, that messed up the chunked encoding resulting in a HTTP response that neither a Content-Length nor a Transfer-Encoding: chunked header.

formidable seems to then expect an empty body, resulting in the error here:

https://github.com/node-formidable/formidable/blob/v1.2.1/lib/incoming_form.js#L159

the _parser is the dummyParser, which does indeed not have a write function:

function dummyParser(self) {
  return {
    end: function () {
      self.ended = true;
      self._maybeEnd();
      return null;
    }
  };
}

Now this is indeed caused by a problem outside of the scope of formidable. It would help tremendously if that error would not disappear uncaught but would instead result in the callback being invoked with some kind of error.

edit: @xarguments @tunnckoCore mention - not sure if you get notified, since this issue has been closed - should I open a new one?

@GrosSacASac
Copy link
Contributor

don't bother if it version 1.x, unless you want to be the maintainer of the 1.x branch

@GrosSacASac
Copy link
Contributor

Maybe check for existing headers before passing it to formidable

@MaxFichtelmann
Copy link
Collaborator

I could provide a PR. I understand the focus on version 2 though.
I will probably end up implementing the check you mentioned.

MaxFichtelmann added a commit to MaxFichtelmann/formidable that referenced this issue Apr 9, 2021
Properly emit an error event when data is supplied even if neither
`Content-Length` nor `Transfer-Encoding is set
MaxFichtelmann added a commit to MaxFichtelmann/formidable that referenced this issue Apr 9, 2021
Properly emit an error event when data is supplied even if neither
`Content-Length` nor `Transfer-Encoding is set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants