respect form hash option on incoming octect/stream requests, enabling… #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… hash calculation
|
See #412 |
|
Fixed in #545 branch |
tunnckoCore
added a commit
that referenced
this pull request
Jan 29, 2020
close #407 Co-authored-by: Claudio Poli <[email protected]> Signed-off-by: Charlike Mike Reagent <[email protected]>
tunnckoCore
added a commit
that referenced
this pull request
Feb 12, 2020
* feat: introduce Plugins API, fix tests * chore: update changelog * chore: lgtm tweaks? * start plugins tests; update exports * chore(custom-plugins-tests): make it really passing * chore: more tests; add nyc test coverage * chore: move to GitHub Actions CI * fix: respect form hash option on incoming octect/stream requests close #407 * fix: tests, use dezalgo and once for parse callback - it is recommended plugins to return the this/self/formidable instance - add 2 deps: `once` and `dezalgo` for ensurance of the `cb` param of .parse() + otherwise it COULD (and happened already few times) be called multiple times - update unit tests to use Jest * chore: tweaks, publish `dev` dist-tag (with Plugins API) * chore: sync & tweak * fix: check strictly for multipart/form-data in multipart parser * chore: publish dev.2 * fix: tests updates * fix: it seems we support multipart/related too * chore: download badges * Update package.json * chore: sync Signed-off-by: Charlike Mike Reagent <[email protected]> Co-authored-by: Claudio Poli <[email protected]>
|
@all-contributors please add @masterkain for code bugfix |
|
I've put up a pull request to add @masterkain! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… hash calculation