Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dual export #944

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Dual export #944

merged 5 commits into from
Jun 28, 2023

Conversation

GrosSacASac
Copy link
Contributor

@GrosSacASac GrosSacASac commented Jun 28, 2023

@phpbg @hannesfant please review

@GrosSacASac GrosSacASac mentioned this pull request Jun 28, 2023
Copy link

@hannesfant hannesfant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GrosSacASac GrosSacASac merged commit 009d3f2 into master Jun 28, 2023
@GrosSacASac GrosSacASac deleted the dual-export branch June 28, 2023 21:11
@GrosSacASac
Copy link
Contributor Author

@bottom-up-ai You can import with cjs now

@laurent22
Copy link

Oh wow, thank you for adding this! I had given up upgrading Formidable since we can't support ESM so this is excellent news.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants