Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flush or fail always (don't hang) #945

Merged
merged 5 commits into from
Aug 25, 2023
Merged

fix: flush or fail always (don't hang) #945

merged 5 commits into from
Aug 25, 2023

Conversation

GrosSacASac
Copy link
Contributor

@stevenwdv
Copy link

Yes this seems to work! Both for valid and invalid/incomplete input it doesn't anymore hang now.

@GrosSacASac
Copy link
Contributor Author

Will merge when I come back

@GrosSacASac GrosSacASac merged commit 1699ec6 into master Aug 25, 2023
2 of 9 checks passed
@GrosSacASac GrosSacASac deleted the flush-multipart-transform-stream-more-often branch August 25, 2023 14:21
@GrosSacASac
Copy link
Contributor Author

published as 3.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MultipartParser does not call callback in _flush if state == STATE.END
2 participants
@GrosSacASac @stevenwdv