fix: make it work on node7.x #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
reviewed
Mar 22, 2017
There was a problem hiding this comment.
Honestly, I don't know enough about this code to be able to judge the correctness of your changes. As long as it works for you, then I think it's ok to land it.
Please check why Travis CI and AppVeyor builds are failing and make sure it's not relate to your change.
|
All set, I think it's time to make a new release~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly because this api https://github.com/nodejs/node/blob/v6.10.0/deps/v8/src/api.cc#L8158 was removed on node 7.x https://github.com/nodejs/node/blob/v7.0.0/deps/v8/src/api.cc#L8268