Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outdated Q library was removed #478

Merged
merged 1 commit into from
Oct 29, 2020
Merged

outdated Q library was removed #478

merged 1 commit into from
Oct 29, 2020

Conversation

gugu
Copy link
Contributor

@gugu gugu commented Oct 29, 2020

Q functions were replaced with corresponding native alternatives,
switching to async/await is not part of this PR

Q functions were replaced with corresponding native alternatives,
switching to async/await is not part of this PR
Copy link
Collaborator

@cjbarth cjbarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the sake of the reviewer, it would be nice if we could have a PR to clear up as many of these warnings from our GitHub Actions as possible :)

Otherwise, thanks for modernizing things so much. This will no doubt help many consumers of this library.

@markstos
Copy link
Contributor

QA Log

  • Reviewed diff, looks good to me. I like that unlike an earlier attempt at this, no shim functions are used, just native functions.

@markstos markstos merged commit 056e6dd into master Oct 29, 2020
@cjbarth cjbarth deleted the remove-q branch February 20, 2021 16:30
@cjbarth cjbarth added the chore Refactoring, etc. to keep code-rot in check. label May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactoring, etc. to keep code-rot in check.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants