Prettier + ESLint + onchange = Happiness #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gugu
reviewed
Nov 3, 2020
| "no-console": 1, // Means warning | ||
| "prettier/prettier": 1 // Warning for now, until we get this cleaned up | ||
| } | ||
| } |
There was a problem hiding this comment.
I think we need to remove eslint config from package.json in this case
There was a problem hiding this comment.
Good point 👍
May I ask what the rationale behind these rules was? I'm wondering if I should move them over or not.
"no-undefined": "off",
"no-unused-vars": "off",
There was a problem hiding this comment.
I'm not the right person for this question) I think these rules should not be disabled, they are helpful
|
Good progress. We'll save this for a future 2.x release |
|
This PR is ready to be reviewed/merged now. |
gugu
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
prettierworking along sideeslint. It doesn't enable anything.I'm marking this as draft because there is a problem with some variable replacement in one watch command that I'm working on, but I wanted to get this out there for review. I imagine that there will be a follow-on PR after this lands that will reformat all the code in one commit.