Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typing): Export Multi SAML types #505

Merged
merged 1 commit into from
Dec 15, 2020
Merged

Conversation

echojoshchen
Copy link
Contributor

Description

A MultiSamlConfig has a getSamlOptions member, but its type is not exported. Exporting these typings allows TypeScript projects to reference the original definition.

For example:

import { MultiSamlStrategy } from "passport-saml";
import type { MultiSamlConfig, SamlOptionsCallback } from "passport-saml/lib/passport-saml/types";

function getSamlOptions(req: express.Request, done: SamlOptionsCallback): void {
  // Implementation
}
const config: MultiSamlConfig = { getSamlOptions };
const strategy: MultiSamlStrategy = new MultiSamlStrategy(config, verify);

Checklist:

  • Issue Addressed: [ ]
  • Link to SAML spec: [ ]
  • Tests included? [ ]
  • Documentation updated? [ ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants