Read me update for authnContext example for ADFS #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjbarth
previously approved these changes
Sep 22, 2021
|
Please run |
Above script works fine in my local. Is there anything I should fix? |
cjbarth
previously approved these changes
Sep 23, 2021
jyenduri-uptycs
dismissed
cjbarth’s stale review
The base branch was changed.
|
I found the problem. It is because our build looks for upcoming potential problems by updating all packages as part of the build. In this case, it uncovered an issue with out code related to an update to TypeScript type checking. This problem is addressed in #641. When that lands, then I'll re-run the build jobs here and this will land just fine. Thanks for your contribution! |
|
Perfect! Thanks @cjbarth |
cjbarth
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the readme document for ADFS example
Bug submitted #642
Checklist: