Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README to require correct module name #884

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

rynop
Copy link
Contributor

@rynop rynop commented Feb 14, 2024

Description

Module name does not match what is documented:

cat node_modules/@node-saml/passport-saml/package.json
{
  "name": "@node-saml/passport-saml",

Checklist:

  • Issue Addressed: [ ]
  • Link to SAML spec: [ ]
  • Tests included? [ ]
  • Documentation updated? [x]

@cjbarth cjbarth changed the title Fix readme to require correct module name Fix README to require correct module name Mar 6, 2024
@cjbarth cjbarth added the documentation Request for or contribution to documentation label Mar 6, 2024
Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.42%. Comparing base (30b1478) to head (0f0ff67).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #884   +/-   ##
=======================================
  Coverage   64.42%   64.42%           
=======================================
  Files           4        4           
  Lines         149      149           
  Branches       37       37           
=======================================
  Hits           96       96           
  Misses         30       30           
  Partials       23       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cjbarth cjbarth merged commit eacbbbb into node-saml:master Mar 6, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Request for or contribution to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants