Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add 'Release Phases' documentation #517

Merged
merged 8 commits into from
Mar 26, 2020

Conversation

BethGriggs
Copy link
Member

Please let me know if you think this should be moved elsewhere.

@BethGriggs BethGriggs requested a review from a team December 31, 2019 16:50
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

Overall this LGTM but I am noticing a bit of a duplication of content between this new section and the release plan section.

Should we perhaps remove duplicated content?

@BethGriggs
Copy link
Member Author

@MylesBorins I'll try and morph the content into the release plan

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BethGriggs BethGriggs self-assigned this Jan 14, 2020
@BethGriggs BethGriggs changed the title doc: add 'Release Phases' documentation [WIP] doc: add 'Release Phases' documentation Jan 16, 2020
@BethGriggs BethGriggs changed the title [WIP] doc: add 'Release Phases' documentation doc: add 'Release Phases' documentation Mar 5, 2020
@BethGriggs
Copy link
Member Author

I've updated this quite significantly to try and reduce duplication. The main changes are:

New features, bug fixes, and updates that have been audited by the LTS team and have been determined to be appropriate and stable for the release line. Changes required for critical security and bug fixes may lead to semver-major changes landing within an LTS stream, such situations will be rare and will land as semver-minor.

The above text is far less specific than what we had before, and defaults to "at the discretion of the release/LTS teams". Please let me know your thoughts on removing the list of specifics changes we land such as npm updates, etc.

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM

Added some small nits inline but none of them are blocking

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

BethGriggs and others added 4 commits March 9, 2020 14:53
@BethGriggs
Copy link
Member Author

Addressed recent comments from @richardlau, @MylesBorins - I think this is good to go now

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some notes that can be ignored and handled in follow up PRs


There are three phases that a Node.js release can be in: 'Current', 'Active
Long Term Support (LTS)', and 'Maintenance'. Odd-numbered release lines are not
promoted to LTS - they will not go through the 'Active LTS' or 'Maintenance'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that odd number releases went through a short maintenance period? is that no longer true?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is true according to the schedule.json- I think we've been purposely vague about it in the past. We can change that - maybe something like "release lines may receive critical fixes shortly after going EOL at the discretion of the Release team"? But I am not sure which is the best approach personally.

README.md Outdated Show resolved Hide resolved
In coordination with a new *odd-numbered* major release, the previous
*even-numbered* major version will transition to Long Term Support. The
transition to Long Term Support will happen in a *semver-minor* release and can
happen either before or after the new major version is released.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to open a follow up issue to track this, if I recall this is the exact thing that caused the "two current releases" thing.

As we will also be transitioning Active LTS releases to maintenance at the same time now we may want to have slightly more robust / clear policy here.

To be clear, not blocking... this should be a follow up.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - I think #495 had some of the conversation tied to it

Co-Authored-By: Myles Borins <[email protected]>
@BethGriggs BethGriggs merged commit 3a9b94b into nodejs:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants