-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nominating RafaelGSS to the TSC #1308
Comments
+1 from me. |
+1 |
2 similar comments
+1 |
+1 |
+1. (Also worth mentioning the contributions and initiatives in the Diagnostics WG.) |
Big +1! Totally deserved! |
I'm always so impressed by how hard @RafaelGSS works and how passionate he is about this work - I'm sure he will be a valuable member of the TSC! +1! |
+1 from me |
+1 |
Definitely +1! |
+1 |
1 similar comment
+1 |
@nodejs/tsc Please comment +1 if you are in favor, -1 if you are against, or if you want to abstain please also say so. Several members have reacted with a 👍 which seems to indicate they are in favor but haven't commented, so please consider doing so :) (@BethGriggs don't forget that you being the one open the issue doesn't mean you can't vote on it, I would need an explicit +1 from you as well). Keeping track of votes in this comment. Yes: 16 (@aduh95, @apapirovski, @BethGriggs, @BridgeAR, @cjihrig, @fhinkel, @GeoffreyBooth, @gireeshpunathil, @jasnell, @joyeecheung, @legendecas, @mhdawson, @RaisinTen, @richardlau, @targos, @Trott) |
+1. I assumed 👍 would count as a vote |
+1 as vote. |
+1 |
+1. I assumed we'd count both 👍🏻 from TSC members and the original nomination as a vote as we have in the past (#1282 (comment)). |
+1 |
In the past, GitHub reactions were understood to count as votes. I can see a reason for changing that in that after enough reactions, it becomes hard to see everyone who reacted. (You can still get the full list from the API but that's not convenient.) I do think, though, that it is abundantly safe to assume that the person who is nominating is voting "yes" and that is what we have always done in the past. |
I can't find it again, but I remember that at some point someone pointed out that reactions are not a great tool for this kind of vote as it doesn't send notifications and it doesn't leave a trace if someone is changing their vote. (or maybe in the API, but comments are just way easier to check.)
Yeah actually, that makes sense, for this kind of issue there's no reason for someone to open a nomination they don't support without saying in the OP they don't support it. |
+1 |
@aduh95 how about we give people 6 days from the time of your comment, I think that might let us close the vote before the next meeting on the 30th. Rafael will be invited for the OSSF discussion anyway but it would be nice to have him confirmed by then. |
I'll have to check to see if any additional TSC member voted from what is tallied in #1308 (comment) but there are no new objections so I think we can considered this complete. I volunteered to onboard @RafaelGSS since @BethGriggs is out this week. I'm going to start that tomorrow. |
+1 |
Starting onboarding
|
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]>
@mcollina and @ronag were +1 in the thumbs up in original post, @danielleadams was in the hurray as well and therefore believe was in the thumbs (which we can't tell) counting them as part of final votes. Let me know if that was not the right thing to do. Based on that I have the final vote as : Yes: 18 (@aduh95, @apapirovski, @BethGriggs, @BridgeAR, @cjihrig, @danielleadams, @fhinkel, @GeoffreyBooth, @gireeshpunathil, @jasnell, @joyeecheung, @legendecas, @mcollina, @mhdawson, @RaisinTen, @richardlau, @ronag, @targos, @Trott) |
@mhdawson I'm going to open a PR to register the vote counting the 👍 and the 🎉 as you're suggesting, and let's see if someone wants to object to it for the sake of following the processes. In any case, it doesn't change the issue of the vote. |
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]>
@aduh95 thanks, that was next on my list of PRs. With that done I'm going to close out this issue. |
* add vote data for RafaelGSS nomination Fixes: #1308 * fix grammar
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]> PR-URL: #45691 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>
Refs: nodejs/TSC#1308 Signed-off-by: Michael Dawson <[email protected]>
I would like to nominate @RafaelGSS to the TSC. In addition to code contributions to Node.js core, Rafael has a record of collaboration across multiple teams and working groups including: Release WG (co-led the recent major release, security releases, and regular releases), Security WG, security release stewarding and triage, and many other groups and teams. He has also led discussions in the project such as security best practices, threat model, and experimental features.
I think Rafael would be a great addition to the TSC and would offer valuable additional context from the many teams he is involved in.
There have been no objections from the private TSC discussion, and I have verified his interest.
The text was updated successfully, but these errors were encountered: