Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: fold the Post-mortem WG into Diagnostics WG #586

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

richardlau
Copy link
Member

Refs: nodejs/post-mortem#48

https://github.com/nodejs/post-mortem has been largely inactive over the last year. I don't believe that's because its activities ceased, rather that the work it was responsible for is happening elsewhere in the organization and, in practice, under the Diagnostics WG. This PR folds the Post-mortem WG into the Diagnostics WG. There were no objections raised in the Post-mortem WG during the nine months since this was proposed in nodejs/post-mortem#48.

@richardlau
Copy link
Member Author

cc @nodejs/post-mortem @nodejs/diagnostics

@Trott
Copy link
Member

Trott commented Aug 15, 2018

If I'm not mistaken, I think this technically means we'd have to vote to de-charter the Postmortem WG. So, this should probably not land without a majority of TSC approving it.

@Trott
Copy link
Member

Trott commented Aug 15, 2018

pinging @nodejs/community-committee just as an FYI. I suspect they like to know when working groups might be disappearing from listings and whatnot.

@richardlau
Copy link
Member Author

Also note that the Diagnostics WG is unchartered. I don't think that matters. I think chartering is over-rated myself. :-D But just mentioning it in case anyone cares.

Huh? It's listed under https://github.com/nodejs/TSC/blob/master/WORKING_GROUPS.md#diagnostics

@Trott
Copy link
Member

Trott commented Aug 15, 2018

pinging @nodejs/tsc because this is (in my interpretation at least) a proposal to de-charter the Postmortem WG so we need folks to actively weigh in on that rather than go with lazy consensus.

@Trott
Copy link
Member

Trott commented Aug 15, 2018

Huh?

D'oh! You're right. Ignore that. Diagnostics is chartered. Related: I should alphabetize the listing in this file so I don't miss a group again like that. :-D

@richardlau
Copy link
Member Author

For a bit more history I believe that originally there were the Tracing WG and Post-mortem WG. Tracing later became Diagnostics (nodejs/diagnostics@ab45c0e) (nodejs/post-mortem#48 (comment)).

@Trott
Copy link
Member

Trott commented Aug 15, 2018

Looks like a Working Group can simply choose to revoke its own charter without a TSC vote, so we may not need majority TSC after all. Probably not a bad idea, though:

A Working Group's charter can be revoked either by consent of the Working Group's members or by a TSC vote

@richardlau
Copy link
Member Author

@Trott I think this is two things:

  1. Decharter the Post-mortem WG
  2. Expand the charter of the Diagnostics WG to include the responsibilities formerly granted by the TSC to the Post-mortem WG

@Trott
Copy link
Member

Trott commented Aug 15, 2018

Ah, yes, expanding charter for Diagnostics definitely requires TSC majority (accounting for abstentions if any). Sorry for all the noise.

@richardlau
Copy link
Member Author

It probably also requires approval from the Diagnostics WG 😁 .

(I'm counting the lack of objections in nodejs/post-mortem#48 as approval from the Post-mortem WG).

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Qard Qard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for Diagnostics WG.

@gireeshpunathil
Copy link
Member

LGTM

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Aug 23, 2018

6 TSC approvals, no objections, open for 7 days. I think this can land, but will leave it to a TSC member who is also on one of the affected WGs (which I think would be @ofrobots @mhdawson @cjihrig @Fishrock123 @jasnell @joyeecheung @mcollina).

Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented Aug 24, 2018

I don't see a reason to leave this open any longer so I'm going to go ahead and merge it. @richardlau Can you take care of making sure the website gets updated?

@Trott Trott merged commit cd3c199 into nodejs:master Aug 24, 2018
@Trott
Copy link
Member

Trott commented Aug 24, 2018

Hmmm...forgot that theoretically this might require a vote? We have 6 TSC so far in favor, so 4 more yes votes (or 7 abstentions) should be enough. Anyone?

@Trott
Copy link
Member

Trott commented Aug 24, 2018

@Fishrock123
Copy link
Contributor

Approve.

@addaleax
Copy link
Member

I’m +1 as well.

@TimothyGu
Copy link
Member

I'm +1.

@danbev
Copy link
Contributor

danbev commented Aug 24, 2018

I'm +1

@MylesBorins
Copy link
Contributor

+1

1 similar comment
@fhinkel
Copy link
Member

fhinkel commented Aug 24, 2018

+1

@Trott
Copy link
Member

Trott commented Aug 24, 2018

Thanks, everyone. We're now well into majority support.

@ChALkeR
Copy link
Member

ChALkeR commented Aug 24, 2018

+1

@richardlau richardlau deleted the assimilate-post-mortem branch August 24, 2018 21:03
@richardlau
Copy link
Member Author

@richardlau Can you take care of making sure the website gets updated?

Will do. It's a public holiday weekend here, so may not get to it until Tuesday.

@gibfahn
Copy link
Member

gibfahn commented Aug 24, 2018

+1 FWIW

@rvagg
Copy link
Member

rvagg commented Aug 25, 2018

👍

1 similar comment
@targos
Copy link
Member

targos commented Aug 25, 2018

+1

richardlau added a commit to richardlau/nodejs.org that referenced this pull request Aug 30, 2018
The Post-mortem working group has been dechartered and its responsibilities handed over to the Diagnostics working group.

Refs: nodejs/TSC#586
@richardlau
Copy link
Member Author

@richardlau Can you take care of making sure the website gets updated?

Raised nodejs/nodejs.org#1786.

fhemberger pushed a commit to nodejs/nodejs.org that referenced this pull request Aug 30, 2018
The Post-mortem working group has been dechartered and its responsibilities handed over to the Diagnostics working group.

Refs: nodejs/TSC#586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.