Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove [=yes|no] from runtime flag #184

Closed
gabrielschulhof opened this issue Mar 22, 2017 · 2 comments
Closed

Remove [=yes|no] from runtime flag #184

gabrielschulhof opened this issue Mar 22, 2017 · 2 comments

Comments

@gabrielschulhof
Copy link
Collaborator

No description provided.

@jasongin jasongin mentioned this issue Mar 22, 2017
Closed
@jasongin
Copy link
Member

At the same time, we should also update the error message to mention the runtime flag, as suggested in this comment?

@gabrielschulhof
Copy link
Collaborator Author

gabrielschulhof commented Mar 22, 2017 •
edited
Loading

Definitely.

  • Remove yes/no
  • update docs
  • mention runtime flag in error

gabrielschulhof pushed a commit to gabrielschulhof/abi-stable-node that referenced this issue Mar 22, 2017
all: update --napi-modules flag to not have a yes/no
48a44c3 
This updates the documentation, the error message upon module load
failure, the command line option parsing of the flag, and the way
the N-API addon tests pass the flag to node.

Re nodejs/node#11975 (comment)
Re nodejs/node#11975 (comment)
Fixes nodejs#184
@gabrielschulhof gabrielschulhof mentioned this issue Mar 22, 2017
Closed
gabrielschulhof pushed a commit to gabrielschulhof/abi-stable-node that referenced this issue Mar 22, 2017
all: update --napi-modules flag to not have a yes/no
6761e6e 
This updates the documentation, the error message upon module load
failure, the command line option parsing of the flag, and the way
the N-API addon tests pass the flag to node.

Re nodejs/node#11975 (comment)
Re nodejs/node#11975 (comment)
Fixes nodejs#184
Closes nodejs#186
gabrielschulhof pushed a commit that referenced this issue Mar 22, 2017
all: update --napi-modules flag to not have a yes/no
ee66ab9 
This updates the documentation, the error message upon module load
failure, the command line option parsing of the flag, and the way
the N-API addon tests pass the flag to node.

Re nodejs/node#11975 (comment)
Re nodejs/node#11975 (comment)
Fixes #184
Closes #186
jasongin pushed a commit to jasongin/nodejs that referenced this issue Mar 23, 2017
@jasongin
all: update --napi-modules flag to not have a yes/no
87c42e7 
This updates the documentation, the error message upon module load
failure, the command line option parsing of the flag, and the way
the N-API addon tests pass the flag to node.

Re nodejs#11975 (comment)
Re nodejs#11975 (comment)
Fixes nodejs/abi-stable-node#184
Closes nodejs/abi-stable-node#186
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabrielschulhof @jasongin