Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document lifetime of napi_get_last_error_info #251

Closed
RReverser opened this issue Jun 11, 2017 · 0 comments
Closed

Document lifetime of napi_get_last_error_info #251

RReverser opened this issue Jun 11, 2017 · 0 comments

Comments

@RReverser
Copy link
Member

Unlike napi_get_cb_info, napi_get_last_error_info doesn’t accept a pointer from callee, but instead is expected to return its own.

For such case it's useful both for implementors and consumers to know the minimal runtime they should keep pointer to the structure and included message around and be able to use it.

As we discussed in the meeting, it likely will be "until the next N-API call".

mhdawson added a commit to mhdawson/io.js that referenced this issue Jun 26, 2017
Document the lifetime of the structure returned
by napi_get_last_error_info

Fixes: nodejs/abi-stable-node#251
addaleax pushed a commit to nodejs/node that referenced this issue Jun 29, 2017
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: #13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
addaleax pushed a commit to nodejs/node that referenced this issue Jul 11, 2017
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: #13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
addaleax pushed a commit to nodejs/node that referenced this issue Jul 18, 2017
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: #13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 10, 2018
Document the lifetime of the structure returned
by napi_get_last_error_info

PR-URL: nodejs#13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this issue Apr 16, 2018
Document the lifetime of the structure returned
by napi_get_last_error_info

Backport-PR-URL: #19447
PR-URL: #13939
Fixes: nodejs/abi-stable-node#251
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Vse Mozhet Byt <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant