Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glibc version on arm64 #1164

Closed
gdams opened this issue Mar 5, 2018 · 4 comments · Fixed by nodejs/node#19164
Closed

glibc version on arm64 #1164

gdams opened this issue Mar 5, 2018 · 4 comments · Fixed by nodejs/node#19164

Comments

@gdams
Copy link
Member

gdams commented Mar 5, 2018

So I was looking at https://github.com/nodejs/node/blob/master/BUILDING.md and I noticed that the supported glibc versions is glibc >= 2.12 on arm64. Looking at the inventory.yml, it would suggest that we build on centos7 which has a glibc version of 2.17.

Would someone be able to confirm if in fact we do have an arm64 machine capable of building at that level otherwise we should probably update that table.

@gibfahn
Copy link
Member

gibfahn commented Mar 5, 2018

Probably a question for @rvagg or @mhdawson

@gdams
Copy link
Member Author

gdams commented Mar 5, 2018

from @gibfahn

[root@release-packetnet-centos7-arm64-1 ~]# /lib64/libc.so.6
GNU C Library (GNU libc) stable release version 2.17, by Roland McGrath et al.
Copyright (C) 2012 Free Software Foundation, Inc.
This is free software; see the source for copying conditions.
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE.
Compiled by GNU CC version 4.8.5 20150623 (Red Hat 4.8.5-16).
Compiled on a Linux 4.5.0 system on 2017-08-24.
Available extensions:
    The C stubs add-on version 2.1.2.
    crypt add-on version 2.1 by Michael Glad and others
    GNU Libidn by Simon Josefsson
    Native POSIX Threads Library by Ulrich Drepper et al
    BIND-8.2.3-T5B
libc ABIs: UNIQUE
For bug reporting instructions, please see:
<http://www.gnu.org/software/libc/bugs.html>.

@rvagg
Copy link
Member

rvagg commented Mar 6, 2018

Yeah, that's the oldest we have for arm64, we used to use ubuntu 14.04 but that was even newer, 2.19. We're not going to go an older than CentOS 7, we already resolved that in an earlier discussion with someone that wanted a more ancient libc iirc, so I'm +1 on updating the docs.

gibfahn added a commit to gibfahn/node that referenced this issue Mar 9, 2018
This is already true in practice.

PR-URL: nodejs#19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Mar 17, 2018
This is already true in practice.

PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this issue Mar 20, 2018
This is already true in practice.

PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
MayaLekova pushed a commit to MayaLekova/node that referenced this issue May 8, 2018
This is already true in practice.

PR-URL: nodejs#19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@BethGriggs
Copy link
Member

Can someone take a look at the updated docs for v8.x to confirm they are accurate? nodejs/node#23275

BethGriggs pushed a commit to nodejs/node that referenced this issue Oct 30, 2018
This is already true in practice.

Backport-PR-URL: #23275
PR-URL: #19164
Fixes: nodejs/build#1164
Reviewed-By: Rod Vagg <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants