Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-macstadium-macos10.10-x64-1 - Unblock 8.12 release #1486

Closed
mhdawson opened this issue Sep 4, 2018 · 22 comments
Closed

release-macstadium-macos10.10-x64-1 - Unblock 8.12 release #1486

mhdawson opened this issue Sep 4, 2018 · 22 comments
Labels

Comments

@mhdawson
Copy link
Member

mhdawson commented Sep 4, 2018

As a heads up:

  • There are issues with the existing 10.10 osx machine which are blocking the release today
  • Normally we would want to add a machine and test on nightlies, but we are starting to add a 10.10 machine to MacStadium as a backup.

This issue is to track/make that visible

@mhdawson
Copy link
Member Author

mhdawson commented Sep 4, 2018

Manual steps here: #1393

@mhdawson
Copy link
Member Author

mhdawson commented Sep 4, 2018

Transferred 2 of the required packages to our stable storage on the ci

downloads@infra-digitalocean-ubuntu14-x64-1:~/www/osx$ ls
Packages.dmg XZ.pkg

@gdams
Copy link
Member

gdams commented Sep 4, 2018

added host: #1487

@gdams
Copy link
Member

gdams commented Sep 4, 2018

following the steps here:

For release machines:

  • Install Packages from http://s.sudre.free.fr/Software/Packages/about.html
  • Install xz utilities from http://macpkg.sourceforge.net/
  • Install Node.js Foundation code signing and package signing certificates
    Available from either the secrets repository under "release" as a passwordless .p12 file
    OS X 10.10: In Keychain Access, "Import Items" and add both the Installer and Application certificates to the "System" (not "login" which is default)
    OS X 10.10: Find the private key for Node.js Foundation under System in Keychain Access, "Get Info" for it, switch to "Access Control" and allow access by all applications. This step requires a physical keyboard under El Capitan and onward.
    Command line alternative (all OS X?): sudo security import /path/to/id.p12 -k /Library/Keychains/System.keychain -T /usr/bin/codesign -T /usr/bin/productsign
    Check with security find-identity -v -p codesigning
  • remove test key and replace with release ssh key
  • Add ssh_config as /Users/iojs/.ssh/config
  • Install the staging key as /Users/iojs/.ssh/id_rsa

@mhdawson
Copy link
Member Author

mhdawson commented Sep 4, 2018

We have created a new machine but I've tagged it so it won't be used by the regular release job since we first need to validate if PackageMaker is needed for 6.x or not. We should also do some testing with nightly releases first.

I have created a new job called " iojs+release-new-osx-temp" that I think I have configured to use the new machine properly.

Running a test build here to see if it builds/publishes ok: https://ci-release.nodejs.org/computer/release-macstadium-macos10.10-x64-1/

If we decide to publish the release with the new machine we should then be able to use this job to run/create the required artifacts.

@mhdawson
Copy link
Member Author

mhdawson commented Sep 5, 2018

Looks like the job passed @MylesBorins FYI. In the worst case we should have a machine/job we can use for osx for 8.x. Would be good to get some additional testing though...

@mhdawson
Copy link
Member Author

mhdawson commented Sep 5, 2018

Job to test if we can properly build a 6.x release without PackageMaker: https://ci-release.nodejs.org/job/iojs+release-new-osx-temp/2/

@rvagg
Copy link
Member

rvagg commented Sep 6, 2018

👍 looking good, I also confirmed in Makefile that we removed the PackageMaker dependency prior to Node 6, so we can expunge that entirely from our records 🎉.
Once we get this online I'd love to get the release machine off my network, maybe the test one too. I could keep them around for backup purposes but maintaining these VMs isn't fun on macOS.

@mhdawson
Copy link
Member Author

mhdawson commented Sep 6, 2018

Test job for 6.x also passed.

@nodejs/build what other testing should we do before switching over to the new machine?

@mhdawson
Copy link
Member Author

@nodejs/build, ping. We might want to \switch over after the 8.12 tomorrow release so that we get a few current releases before the 10.X goes LTS. @MylesBorins any suggestions/concerns over timing for a switch over?

@joaocgreis
Copy link
Member

@mhdawson for Windows machines I build a test release, and make sure it can be installed and native modules can be compiled with/for it. Make sure the package is signed (ref nodejs/node#14179, though there's not much of a conclusion there). Not sure if there's anything else specific for osx, but if the items above work it should be ok to add to the pool. I'd keep both around for a few days, since the old one is working now.

@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 11, 2018 via email

@mhdawson
Copy link
Member Author

@gdams could you take the action to complete the steps that @joaocgreis suggests. I think Rod may have validated some of those, but a complete check makes sense. Earlier test build was here: k: https://ci-release.nodejs.org/computer/release-macstadium-macos10.10-x64-1/, and one for 6.x here. We probably also want to test 10.x: kicking off build https://ci-release.nodejs.org/job/iojs+release-new-osx-temp/3/

Let me know if you need me to kick off any other builds or need help mapping the builds to test releases published on the Node.js web site.

@refack
Copy link
Contributor

refack commented Oct 16, 2018

Since the requireIO issue has reemerged, I relabed the machines. Last node10 nightly was built on release-macstadium-macos10.10-x64-1.

/CC @nodejs/releasers @targos

@MylesBorins
Copy link
Contributor

@refack this rebase seems to have regressed the xz tar utility and is potentially blocking our LTS release tomorrow. Is someone able to fix this ASAP?

@MylesBorins
Copy link
Contributor

It seems like the machine may need the below step manually done again.

This is blocking the 10.13.0 LTS release, can someone please fix this ASAP

@rvagg
Copy link
Member

rvagg commented Oct 30, 2018

FYI I've asked to break contract with my ISP over the network problem they haven't resolved, but they want one last chance to try and fix it, hoping to have it resolved this week one way or another.

@MylesBorins
Copy link
Contributor

quoting @rvagg in #1551

OK, yeah, start.sh didn't match #1511. Rebuilt @ https://ci-release.nodejs.org/job/iojs+release/3878/nodes=osx1010-release-tar/ and it's all good. You have a .xz now.

@mhdawson
Copy link
Member Author

@gdams still hoping you are going to complete the planned steps, unless other people from the @nodejs/build don't think we need to as the machine is already being used for releases...

@mhdawson
Copy link
Member Author

@MylesBorins looking at the issue in #1551 it sounds like the machine was fixed up and is now ok.

@github-actions
Copy link

github-actions bot commented Mar 7, 2020

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is remove or a comment is made.

@github-actions github-actions bot added the stale label Mar 7, 2020
@mhdawson
Copy link
Member Author

mhdawson commented Mar 9, 2020

I think this is done, closing.

@mhdawson mhdawson closed this as completed Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants