Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggestion: we enable the "stale" bot on nodejs/build #2190

Closed
sam-github opened this issue Feb 19, 2020 · 8 comments · Fixed by #2196
Closed

suggestion: we enable the "stale" bot on nodejs/build #2190

sam-github opened this issue Feb 19, 2020 · 8 comments · Fixed by #2196

Comments

@sam-github
Copy link
Contributor

stale bot: https://github.com/apps/stale

Its used for a few other repos associated with Node.js (like libuv).

IMO, it would make a non-judgemental way to clean up stale issues. Note that we have 182 issues, and about 3/8th of them (judging by page counts) have not been updated since 2018. I think this is starting to snowball, there are so many, we inadvertently create duplicates, and we can't easily seperate the "this really needs doing" from the "wouldn't it be nice if ..." issues. Even going through all those issues would take time away from actually making progress on them.

Note that the stale bot won't close anything if anyone makes a comment, any comment. Its process is basically:

  • Make a comment saying the issue is stale after a configurable number of days of inactivity.
  • Close stale issues after a configurable number of days passes after the issue was marked stale.

Everyone gets a chance to disagree on staleness by posting, some labels can be designated as "never stale", and of course its github.... we can reopen issues if we ever need to.

@bnb
Copy link

bnb commented Feb 24, 2020

I would love to see this bot be able to be opt-in for repos across the organization. There are several repos that could benefit from it.

@richardlau
Copy link
Member

Another option is the GitHub Actions stale action: https://github.com/actions/stale

@sam-github
Copy link
Contributor Author

Since we are already using actions, I assume that would be lower barrier to entry.

@nodejs/build - any comments pro or con?

@sam-github
Copy link
Contributor Author

In case we do decide to try this: #2196

@trivikr
Copy link
Member

trivikr commented Feb 25, 2020

Prior discussions with some consensus on stale action or stale bot but no follow-ups:

Configs finalized for nodejs/node:

  • daysUntilStale: 60
  • daysUntilClose: 365

nodejs/node#29232 (comment)

@Trott
Copy link
Member

Trott commented Feb 25, 2020

I'm +1 on at least trying this in the Build repo and seeing how it works for us.

@mhdawson
Copy link
Member

I'm +1. In the worst case we can re-open issues and the barrier to keeping an issue open (commenting) is low. Even though we may end up with closed issues for things we still want to do, if we have not gotten to then in a long time and we don't remember them without an issue then we probably have higher priorities anyway.

sam-github added a commit that referenced this issue Mar 4, 2020
Setup to mark stale after 300 days, and close 30 days after marked stale
unless the issue is commented on, or has the `stale` label removed.

The 'never stale' label can be used to exempt an issue from ever being
considered stale.

Fixes: #2190
@sam-github
Copy link
Contributor Author

So, I enabled it. I hope. Its my first attempt, so if all goes well (?) there will be a flood of notifications at midnight UTC for issues with no activity in the last 300 days. If that doesn't happen, I got the config wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants