v12.x LTS expected assets need updating

[codebytere]

Discovered during the latest v12.16.2 release:

# Promoting v12.16.2...
... Checking assets
... Expecting a total of 39 assets for v12.x
... 40 assets waiting in staging
... 0 assets already promoted
 ✓  Complete set of expected assets in place for v12.x
 ✖  The following assets were found in staging but are not expected for v12.x:
    • docs/previous-versions.json
    Does the expected assets list for v12.x need to be updated?
    https://github.com/nodejs/build/tree/master/ansible/www-standalone/tools/promote/expected_assets/v12.x

I think that just means adding the new asset here?

[targos]

This was added in nodejs/node#32518

@richardlau is it expected to be part of the published assets?

[richardlau]

This was added in nodejs/node#32518

@richardlau is it expected to be part of the published assets?

Didn’t expect that. The file doesn’t need to be there as it’s only used in building the docs and not referenced by the built docs.

[codebytere]

Hmm - is there a solution moving forward that's not just adding it to expected assets?

[richardlau]

Hmm - is there a solution moving forward that's not just adding it to expected assets?

nodejs/node#32728 moves (and renames) the file so that it is outside of out/doc which should prevent it being published.

[codebytere]

Thanks @richardlau - I'll close my PR!

[rvagg]

can I just say, yay 🍾 for expected-assets, working really nicely if it's even picking up things like this.