Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding F3n67u to the build wg #3003

Closed
RaisinTen opened this issue Jul 24, 2022 · 8 comments
Closed

Onboarding F3n67u to the build wg #3003

RaisinTen opened this issue Jul 24, 2022 · 8 comments
Labels
build-agenda

Comments

@RaisinTen
Copy link
Contributor

While I was onboarding @F3n67u as a collaborator yesterday, I followed the onboarding guide in the core repo and it mentions this:

https://github.com/nodejs/node/blob/main/onboarding.md#fifteen-minutes-before-the-onboarding-session

Fifteen minutes before the onboarding session

  • Prior to the onboarding session, add the new Collaborator to
    the collaborators team.
  • Ask them if they want to join any subsystem teams. See
    [Who to CC in the issue tracker][who-to-cc].

Feng expressed interest in joining the Build WG, so I assumed that I was supposed to add him there and I did so. However, now I realize that the build repo has its own governance and onboarding documents, so I feel that maybe that was not the right thing to do, so I have removed Feng from the build team.

I wanted to know what should be done here. Is anyone else from the @nodejs/build team going to onboard Feng to this group or is there anything else that we should do first?
@Trott
Copy link
Member

Trott commented Jul 26, 2022

I added build-agenda label so this at least gets on the next meeting agenda if no one replies between now and then.

@mhdawson
Copy link
Member

We should probably fix that onbording guidance there are probably a number of teams which require more than just showing interest as a prereq for being added.

@targos
Copy link
Member

targos commented Jul 27, 2022

Maybe the docs should link to https://github.com/orgs/nodejs/teams/core/teams for a list of what we consider "subsystem teams"

@RaisinTen
Copy link
Contributor Author

RaisinTen commented Jul 27, 2022 •
edited
Loading

https://github.com/orgs/nodejs/teams/core/teams

That page is not visible to people who are not members of the org, so they would have lesser time to decide which teams they would like to join. Previously, they had days to decide but if we do this, it would be a 15 minute window. This might not be a problem but I thought we should take this into consideration.

@mhdawson
Copy link
Member

I don't think it should be a big deal if they have 15 mins to decide, they would have access after being a org member and could later ask to join a team?

RaisinTen added a commit to RaisinTen/node that referenced this issue Jul 28, 2022
@RaisinTen
doc: clarify part of onboarding guide regarding adding to teams
60e7123 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>
@RaisinTen RaisinTen mentioned this issue Jul 28, 2022
Merged
@RaisinTen
Copy link
Contributor Author

Sent nodejs/node#44024 to fix the onboarding doc.

@mhdawson
Copy link
Member

@RaisinTen thanks!

nodejs-github-bot pushed a commit to nodejs/node that referenced this issue Jul 31, 2022
@RaisinTen
doc: clarify part of onboarding guide regarding adding to teams
7192ec1 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #44024
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@mhdawson mhdawson mentioned this issue Aug 1, 2022
Closed
danielleadams pushed a commit to nodejs/node that referenced this issue Aug 16, 2022
@RaisinTen @danielleadams
doc: clarify part of onboarding guide regarding adding to teams
c7fdc53 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #44024
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@mhdawson mhdawson mentioned this issue Aug 22, 2022
Closed
ruyadorno pushed a commit to nodejs/node that referenced this issue Aug 23, 2022
@RaisinTen @ruyadorno
doc: clarify part of onboarding guide regarding adding to teams
7f7a0eb 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #44024
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Sep 5, 2022
@RaisinTen @targos
doc: clarify part of onboarding guide regarding adding to teams
5885b97 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #44024
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@mhdawson mhdawson mentioned this issue Sep 12, 2022
Closed
Fyko pushed a commit to Fyko/node that referenced this issue Sep 15, 2022
@RaisinTen @Fyko
doc: clarify part of onboarding guide regarding adding to teams
c3d1ef3 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: nodejs#44024
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@mhdawson mhdawson mentioned this issue Oct 3, 2022
Closed
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 10, 2022
@RaisinTen @juanarbol
doc: clarify part of onboarding guide regarding adding to teams
a794976 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #44024
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
juanarbol pushed a commit to nodejs/node that referenced this issue Oct 11, 2022
@RaisinTen @juanarbol
doc: clarify part of onboarding guide regarding adding to teams
5a34c57 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: #44024
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@mhdawson mhdawson mentioned this issue Oct 24, 2022
Closed
@mhdawson mhdawson mentioned this issue Nov 14, 2022
Closed
@mhdawson mhdawson mentioned this issue Dec 5, 2022
Closed
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@RaisinTen @guangwong
doc: clarify part of onboarding guide regarding adding to teams
3157925 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: nodejs/node#44024
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
guangwong pushed a commit to noslate-project/node that referenced this issue Jan 3, 2023
@RaisinTen @guangwong
doc: clarify part of onboarding guide regarding adding to teams
461309c 
There are a number of teams (for example, the build team) which require
more than just showing interest as a prerequisite for being added, so
this change adds a link to the set of subsystem teams where new
Collaborators can be added directy.

Also, the doc didn't actually mention if the new Collaborator should be
added to the team. This change also clarifies that.

Refs: nodejs/build#3003
Signed-off-by: Darshan Sen <[email protected]>

PR-URL: nodejs/node#44024
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
@mhdawson mhdawson mentioned this issue Jan 16, 2023
Closed
@mhdawson mhdawson mentioned this issue Feb 6, 2023
Closed
This was referenced Feb 21, 2023
Closed
Closed
@mhdawson mhdawson mentioned this issue Mar 20, 2023
Closed
@mhdawson mhdawson mentioned this issue Apr 10, 2023
Closed
@UlisesGascon
Copy link
Member

As agreed in #3299 I will close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-agenda
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@Trott @targos @UlisesGascon @mhdawson @RaisinTen