Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

headers.tar.gz packages are missing from recent nightly builds #743

Closed
jasongin opened this issue May 31, 2017 · 6 comments
Closed

headers.tar.gz packages are missing from recent nightly builds #743

jasongin opened this issue May 31, 2017 · 6 comments

Comments

@jasongin
Copy link
Member

The nightly build directories from 4 days ago and prior include headers.tar.gz/.xz packages, as expected:

But those packages are missing from the last 3 nightly builds:

A significant effect is that, after installing the nightly build, node-gyp will fail to download the headers, and therefore fail to build native addons:

> node-gyp rebuild

gyp WARN install got an error, rolling back install
gyp ERR! configure error 
gyp ERR! stack Error: 404 response downloading https://nodejs.org/dist/v8.0.0-nightly20170530effeff1843/node-v8.0.0-nightly20170530effeff1843-headers.tar.gz
gyp ERR! stack     at Request.<anonymous> (/home/travis/.nvs/nightly/8.0.0-nightly20170530effeff1843/x64/lib/node_modules/npm/node_modules/node-gyp/lib/install.js:210:14)
gyp ERR! stack     at emitOne (events.js:120:20)
gyp ERR! stack     at Request.emit (events.js:210:7)
gyp ERR! stack     at Request.onRequestResponse (/home/travis/.nvs/nightly/8.0.0-nightly20170530effeff1843/x64/lib/node_modules/npm/node_modules/request/request.js:1074:10)
gyp ERR! stack     at emitOne (events.js:115:13)
gyp ERR! stack     at ClientRequest.emit (events.js:210:7)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient (_http_client.js:563:21)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:116:23)
gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:452:20)
gyp ERR! stack     at emitOne (events.js:115:13)
gyp ERR! System Linux 4.8.12-040812-generic
gyp ERR! command "/home/travis/.nvs/nightly/8.0.0-nightly20170530effeff1843/x64/bin/node" "/home/travis/.nvs/nightly/8.0.0-nightly20170530effeff1843/x64/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /home/travis/build/jasongin/node-addon-api/test
gyp ERR! node -v v8.0.0-nightly20170530effeff1843
gyp ERR! node-gyp -v v3.6.1
gyp ERR! not ok 
@bnoordhuis
Copy link
Member

nodejs/node#12719 (comment) is relevant, error when building the documentation with make doc:

/Users/iojs/build/ws/tools/doc/node_modules/marked/lib/marked.js:1062
      while (this.next().type !== 'list_item_end') {
                        ^

TypeError: Cannot read property 'type' of undefined

@mhdawson
Copy link
Member

Strangely make doc seemed to fail before this PR landed and passed afterwareds nodejs/node#13274

@mhdawson
Copy link
Member

It failed in generating errors.md which was the one changed by that PR.

@mhdawson
Copy link
Member

mhdawson commented Jun 1, 2017

@jasongin can you check if last nights builds were ok ? I'm wondering if the PR I mentioned fixed the doc issue.

@gibfahn
Copy link
Member

gibfahn commented Jun 1, 2017

Header packages are there in the latest nightly (assuming this is the right one):

https://nodejs.org/download/nightly/v9.0.0-nightly20170531102e1aa4e3/

image

@jasongin
Copy link
Member Author

jasongin commented Jun 1, 2017

Yes, the latest nightly build looks good. Closing.

@jasongin jasongin closed this as completed Jun 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants