Update CI to include node 4, 6, 8, nightly, CC nightly #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| - nvs add $NODEJS_VERSION | ||
| - nvs use $NODEJS_VERSION | ||
| - node --version | ||
| - npm --version |
There was a problem hiding this comment.
curious - Is this just use to log which node/npm version was used?
There was a problem hiding this comment.
Yes, just for reference when something fails. Most CI scripts I've seen do this.
|
|
addaleax
approved these changes
May 31, 2017
mhdawson
approved these changes
May 31, 2017
kfarnung
approved these changes
May 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Travis run: https://travis-ci.org/jasongin/node-addon-api/builds/237732241
AppVeyor run: https://ci.appveyor.com/project/jasongin/node-api/build/3
All jobs in the matrix are passing with the exception of those that use node nightly builds, which fail due to nodejs/build#743