Refactor the Windows world #1383
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
|
Will this cover what's added in #708? |
|
@nodejs/build I plan to land this soon. Please keep in mind that this is only good for creating new machines, I don't know if this will run well on existing ones. I will keep working on this, I plan to review our current inventory and update |
joaocgreis
added a commit
that referenced
this pull request
Jun 29, 2018
This removes all Windows machines from both `ansible/` and `setup/` inventories. The new scripts added here should only be used to create new machines for now, the inventory will be reviewed later. The `windows-servers.md` files in secrets have the current updated list of Windows machines. PR-URL: #1383 Reviewed-By: Jon Moss <[email protected]>
|
Landed in 054bb4e. Thanks for your review @maclover7! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the Windows Ansible scripts to
ansible/. Since some refactoring was necessary to make them fit, I took the opportunity to change most packages to install from Chocolatey.This can be used to deploy new workers, but I'm not sure it can be safely used to refresh the current ones. Hence, this does not include changes in the inventory yet. I will keep working on this. When that happens, I will merge the
create-windows.ymlintocreate.yml.cc @maclover7