Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ansible,jenkins: use gcc 10 on RHEL 8 for Node.js 20 #3249

Merged
merged 1 commit into from
Mar 23, 2023
Merged

ansible,jenkins: use gcc 10 on RHEL 8 for Node.js 20 #3249

merged 1 commit into from
Mar 23, 2023

Conversation

richardlau
Copy link
Member

@richardlau
Copy link
Member Author

I've deployed the Ansible changes onto all of the test and release RHEL8 systems (including the three Ubuntu 2004 arm64 docker hosts which are running RHEL8 containers). Builds won't use gcc10 until the select-compiler.sh script changes in this PR land.

This doesn't address the cross-compiler for armv7l -- that will need to be updated separately.

mhdawson
mhdawson approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richardlau richardlau merged commit 4907bbc into nodejs:main Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
ansible platform:arm platform:linux-intel platform:linuxONE platform:ppc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardlau @targos @mhdawson