Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add v8-canary builds to www setup #757

Closed
wants to merge 1 commit into from
Closed

add v8-canary builds to www setup #757

wants to merge 1 commit into from

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Jun 12, 2017

some chakracore stuff in there too that's come in from an upstream sync

gibfahn

This comment was marked as off-topic.

gibfahn

This comment was marked as off-topic.

joaocgreis

This comment was marked as off-topic.

@joaocgreis
Copy link
Member

For reference, the ChakraCore changes had been in #547 , I didn't land them because I wanted to keep it more dynamic, but it's been there for a while and there's no harm in landing either.

@joaocgreis
Copy link
Member

@rvagg looking at https://github.com/nodejs/build/pull/547/files , user.yaml has two entries: dist and staging directories. Isn't this PR missing the staging one?

joaocgreis

This comment was marked as off-topic.

@rvagg rvagg closed this Nov 8, 2017
@rvagg rvagg deleted the www-v8-canary branch November 8, 2017 11:29
@rvagg
Copy link
Member Author

rvagg commented Nov 8, 2017

fixed the problem in user.yml that @joaocgreis pointed out and merged it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants