Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Fix CoC section in CONTRIBUTING.md #133

Merged
merged 3 commits into from
Sep 28, 2017
Merged

Fix CoC section in CONTRIBUTING.md #133

merged 3 commits into from
Sep 28, 2017

Conversation

jsynowiec
Copy link
Contributor

This PR fixes the link to CoC and the name of Node.js Foundation in the CONTRIBUTING.md file.

bnb

This comment was marked as off-topic.

Sign in to view

@jsynowiec
Copy link
Contributor Author

We've also discussed rewording of

(...) requires of its contributors

to either "requires off of" or "requires from".
We've concluded that the latter can be considered better, and changed it to "requires from all contributors" (nodejs/evangelism@bef9702). If you agree I'll be happy to update this PR with similar change.

mhdawson

This comment was marked as off-topic.

Sign in to view

@mhdawson
Copy link
Member

I like "from" better as well.

@bnb bnb added the cc-agenda label Sep 27, 2017
@bnb bnb mentioned this pull request Sep 28, 2017
Closed
@rachelnicole rachelnicole merged commit df16123 into nodejs:master Sep 28, 2017
@rachelnicole
Copy link
Contributor

Approved per meeting agenda during CommComm for 9/28

#136 (comment)

@jsynowiec jsynowiec deleted the fix-contributing-coc branch September 28, 2017 16:16
@bnb bnb removed the cc-agenda label Feb 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mhdawson mhdawson mhdawson approved these changes

@bnb bnb bnb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsynowiec @mhdawson @rachelnicole @bnb