-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rules: accept revert commit titles that were elongated by git #99
rules: accept revert commit titles that were elongated by git #99
Conversation
This change ensures that the commit message linter doesn't reject revert commits that originally had commit titles with an acceptable length but were elongated during the revert process by running `git revert`. Fixes: nodejs#97 Signed-off-by: Darshan Sen <[email protected]>
7d75f52
to
9a6759f
Compare
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
==========================================
+ Coverage 93.88% 93.89% +0.01%
==========================================
Files 19 19
Lines 458 459 +1
==========================================
+ Hits 430 431 +1
Misses 28 28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If a revert is reverted, doesn't git turn that into Revert "Revert "...""
? Maybe that changed or I am misremembering, but if it does, this should maybe account for that.
@tniessen you're correct about the generated commit title but it seems |
@richardlau since you've been creating most of the releases for this repo recently, I thought I should ask you if you could give my npm account (https://www.npmjs.com/~raisinten) enough permissions, so that I can publish v3.16.1 with this change please? (I get this error when I run |
@RaisinTen I've added you via
|
@richardlau thanks, I've published v3.16.1! :-) |
This change ensures that the commit message linter doesn't reject
revert commits that originally had commit titles with an acceptable
length but were elongated during the revert process by running
git revert
.Fixes: #97
Signed-off-by: Darshan Sen [email protected]