-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proposal: elevate diagnostic report to tier1 #369
Comments
On the WG meeting, we decided to ping the working group members then wait 7 days before we open a PR with tier bump. |
cc @nodejs/diagnostics |
The current https://github.com/nodejs/node/blob/master/doc/guides/diagnostic-tooling-support-tiers.md#diagnostic-tooling-support-tiers doesn't mention diagnostic report at all, so this would be adding diagnostic report as tier 1 rather than elevating it.
|
I don't understand - can you elaborate? the guide does not mention diagnostic report, because:
|
They've diverged and |
ok - so you are talking about the grace period when both (node-report and diagnostic-report) will co-exist due to logistical / policy related reasons. I am talking about diagnostic-report as a replacement of node-report (reasons and background in the first comment of nodejs/node#22712) which is a result of endorsement from this working group. I am seeking a similar endorsement in this WG to replace node-report from the (unclassified) tooling tiers with diagnostic-report as classified. |
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
this is achieved, closing. thanks all! |
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
diagnostic report qualifies for all the criteria for being in tier1. Classify it as such. PR-URL: #32732 Refs: nodejs/diagnostics#369 Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]>
refs: https://github.com/nodejs/node/blob/master/doc/guides/diagnostic-tooling-support-tiers.md
diagnostic report meets all the criteria required for being tier1, namely:
I propose to elevate report to tier1 status.
The text was updated successfully, but these errors were encountered: