Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove EOL Jessie variants, update Stretch LTS arches #1298

Merged
merged 2 commits into from
Jul 28, 2020
Merged

Remove EOL Jessie variants, update Stretch LTS arches #1298

merged 2 commits into from
Jul 28, 2020

Conversation

tianon
Copy link
Contributor

@tianon tianon commented Jul 23, 2020

@tianon tianon mentioned this pull request Jul 23, 2020
Closed
@SimenB
Copy link
Member

SimenB commented Jul 23, 2020

This shouldn't be considered a breaking change, I think. @nodejs/docker thoughts?

@tianon tianon mentioned this pull request Jul 24, 2020
Closed
@Starefossen
Copy link
Member

This shouldn't be considered a breaking change, I think. @nodejs/docker thoughts?

Looks good to me 👍🏼

@djmitche djmitche mentioned this pull request Jul 25, 2020
Closed
1 task
PeterDaveHello
PeterDaveHello approved these changes Jul 26, 2020
View reviewed changes
Copy link
Member

@PeterDaveHello PeterDaveHello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should also remove the mention of jessie in SECURITY.md later.

@SimenB SimenB mentioned this pull request Jul 28, 2020
Closed
@SimenB
Copy link
Member

SimenB commented Jul 28, 2020

Not sure why Travis thinks it should build some jessie stuff?

@SimenB
Copy link
Member

SimenB commented Jul 28, 2020

Pushing again now for some reason skipped them 🤷

@SimenB SimenB merged commit 34b507f into nodejs:master Jul 28, 2020
@nodejs-github-bot nodejs-github-bot mentioned this pull request Jul 28, 2020
Merged
@nodejs-github-bot
Copy link
Collaborator

Created PR to the official-images repo (docker-library/official-images#8442). See https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what if you are wondering when it will be available on the Docker Hub.

@GrahamCampbell
Copy link

Not sure why Travis thinks it should build some jessie stuff?

Travis seems to have a bug where it fetches old config. I've noticed it a lot on other repos over the last few days too. I guess they are not waiting long enough for GitHub's replica databases to catch up.

@tianon tianon deleted the debian-eol branch July 28, 2020 14:09
This was referenced Jul 28, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterDaveHello PeterDaveHello PeterDaveHello approved these changes

@SimenB SimenB SimenB approved these changes

@Starefossen Starefossen Starefossen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tianon @SimenB @Starefossen @nodejs-github-bot @GrahamCampbell @PeterDaveHello