Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node to 5.2.0 #76

Merged
merged 1 commit into from
Dec 9, 2015
Merged

Conversation

jbergstroem
Copy link
Member

Because its new. Assume I screwed this PR up! :)

@Starefossen
Copy link
Member

The Docker files looks solid to me, however we only keep the latest version of each supported major version on the repo. So rather than add a new 5.2 directory we just rename 5.1 and update the NODE_VERSION variables.

Also, when updating the latest stable version, the Docker Registry updater file needs to be changed https://github.com/nodejs/docker-node/blob/master/generate-stackbrew-library.sh#L8

@jbergstroem
Copy link
Member Author

@Starefossen thanks for the feedback. Rebased against master and pushed a new commit.

@Starefossen
Copy link
Member

Thanks 👍 Merged.

Starefossen added a commit that referenced this pull request Dec 9, 2015
@Starefossen Starefossen merged commit 062488d into nodejs:master Dec 9, 2015
@Starefossen
Copy link
Member

Now, clone https://github.com/docker-library/official-images and from the docker-node repo run the following command before submitting a PR back to the official-images repo.

$ ./generate-stackbrew-library.sh > /path/to/docker-library/official-images/library/node

@jbergstroem
Copy link
Member Author

Thanks for merging. I gotta run -- suggest someone else does above unless a few hours of wait is ok.

Starefossen pushed a commit to Starefossen/official-images that referenced this pull request Dec 9, 2015
Related: nodejs/node#4181
Related: nodejs/docker-node#76

Signed-off-by: Hans Kristian Flaatten <[email protected]>
@Starefossen
Copy link
Member

PR to the official registry submitted 😄

@Starefossen
Copy link
Member

v5.2.0 is now live on Docker Hub ✨🐳🐢🚀✨

pierreozoux pushed a commit to pierreozoux/official-images that referenced this pull request Jan 7, 2016
Related: nodejs/node#4181
Related: nodejs/docker-node#76

Signed-off-by: Hans Kristian Flaatten <[email protected]>
RichardScothern pushed a commit to RichardScothern/official-images that referenced this pull request Jun 14, 2016
Related: nodejs/node#4181
Related: nodejs/docker-node#76

Signed-off-by: Hans Kristian Flaatten <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants