esm: rename flag --esm-extension-resolution

There are currently two supported values "none" and "auto"
nodejs · Mar 5, 2019 · d6a3b09 · d6a3b09
1 parent 2168312
commit d6a3b09
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/default.profraw b/default.profraw
diff --git a/src/module_wrap.cc b/src/module_wrap.cc
@@ -699,7 +699,7 @@ inline Maybe<URL> ResolveIndex(const URL& search) {
 Maybe<URL> FinalizeResolution(Environment* env,
                               const URL& resolved,
                               const URL& base) {
-  if (env->options()->legacy_resolution) {
+  if (env->options()->esm_extension_resolution == "auto") {
     Maybe<URL> file = ResolveExtensions<TRY_EXACT_NAME>(resolved);
     if (!file.IsNothing()) {
       return file;

diff --git a/src/node_options.cc b/src/node_options.cc
@@ -236,9 +236,9 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             "(default: llhttp).",
             &EnvironmentOptions::http_parser,
             kAllowedInEnvironment);
-  AddOption("--legacy-resolution",
-            "legacy extension and folder resolution for ES Modules",
-            &EnvironmentOptions::legacy_resolution,
+  AddOption("--esm-extension-resolution",
+            "Select extension resolution algorithm for esm; either 'none' or 'auto'",
+            &EnvironmentOptions::esm_extension_resolution,
             kAllowedInEnvironment);
   AddOption("--no-deprecation",
             "silence deprecation warnings",

diff --git a/src/node_options.h b/src/node_options.h
@@ -86,7 +86,7 @@ class EnvironmentOptions : public Options {
  public:
   bool abort_on_uncaught_exception = false;
   bool experimental_modules = false;
-  bool legacy_resolution = false;
+  std::string esm_extension_resolution = "none";
   std::string module_type;
   std::string experimental_policy;
   bool experimental_repl_await = false;