Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert edit of existing PR comment back to creating new comments #240

Merged
merged 1 commit into from
Jun 15, 2019

Commits on Jun 15, 2019

  1. jenkins: revert edit of existing comment back to create a new comment

    Reverting changes related to editing existing comments, going back
    to the previous behaviour of always creating new comments in PRs about
    CI / Jenkins runs.
    
    This is done primarily due to two things:
    
    * It has broken node-core-utils' ability to check if CI's have been run
    * There's not collaborator consensus about editing comments is actually
      better than creating new comments
    
    Future plans for bot PR comments going forward has to be discussed more
    thorougly and ensured it doesn't break other automation tools used
    by collaborators.
    
    Refs nodejs#228
    phillipj committed Jun 15, 2019
    Configuration menu
    Copy the full SHA
    72712e1 View commit details
    Browse the repository at this point in the history