Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support same file name on windows #60

Closed
gengjiawen opened this issue Aug 5, 2020 · 0 comments · Fixed by #62
Closed

support same file name on windows #60

gengjiawen opened this issue Aug 5, 2020 · 0 comments · Fixed by #62

Comments

@gengjiawen
Copy link
Member

Mainly to fix nodejs/node-v8#161 (comment)

In short: Windows .obj files generated in flattened directory causing linker errors
gengjiawen added a commit to gengjiawen/node that referenced this issue Aug 23, 2020
@gengjiawen
deps: hack for gyp flaw on windows
7b2e7f9 
See: nodejs/gyp-next#60
@gengjiawen gengjiawen mentioned this issue Aug 23, 2020
Closed
@gengjiawen gengjiawen mentioned this issue Sep 7, 2020
Closed
@targos targos self-assigned this Sep 7, 2020
targos added a commit to targos/gyp-next that referenced this issue Sep 7, 2020
@targos
feat: support source files with duplicate basename
5e4f448 
This change removes the duplicate basename checks for macOS and MSVS.
The macOS one is no longer necessary and the solution generator for MSVS
is updated to support duplicate names by reproducing the source
directory structure in the intermediate directory.

Closes: nodejs#60

BREAKING CHANGE:

The `--no-duplicate-basename-check` option is removed.
targos added a commit to targos/gyp-next that referenced this issue Sep 7, 2020
@targos
feat: support source files with duplicate basename
5a2f357 
This change removes the duplicate basename checks for macOS and MSVS.
The macOS one is no longer necessary and the solution generator for MSVS
is updated to support duplicate names by reproducing the source
directory structure in the intermediate directory.

Closes: nodejs#60

BREAKING CHANGE:

The `--no-duplicate-basename-check` option was removed.
@targos targos mentioned this issue Sep 7, 2020
Merged
targos added a commit to targos/gyp-next that referenced this issue Sep 7, 2020
@targos
feat: support source files with duplicate basename
bba609e 
This change removes the duplicate basename checks for macOS and MSVS.
The macOS one is no longer necessary and the solution generator for MSVS
is updated to support duplicate names by reproducing the source
directory structure in the intermediate directory.

Closes: nodejs#60

BREAKING CHANGE:

The `--no-duplicate-basename-check` option was removed.
@targos targos removed their assignment Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support source files with duplicate basename targos/gyp-next
2 participants
@targos @gengjiawen