This repository has been archived by the owner on Nov 6, 2022. It is now read-only.
Fix: Content-Length with obsolete line folding and invalid input #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id input - treat obsolete line folding as space and continue parsing - update tests
bnoordhuis
approved these changes
Dec 23, 2018
http_parser.c
Outdated
| @@ -1434,6 +1434,10 @@ size_t http_parser_execute (http_parser *parser, | |||
| parser->header_state = h_content_length_num; | |||
| break; | |||
|
|
|||
| // when obsolete line folding is encountered for content length continue to the s_header_value state | |||
There was a problem hiding this comment.
Can you use C89-style comments and wrap at 80 columns? Thanks.
bnoordhuis
pushed a commit
that referenced
this pull request
Dec 24, 2018
Content-Length with line folding was accepted with invalid input. Treat obsolete line folding as space and continue parsing Fixes: #456 PR-URL: #458 Reviewed-By: Ben Noordhuis <[email protected]>
|
Thanks for your contribution, Olga. Merged in cd88eef. |
ploxiln
pushed a commit
to ploxiln/http-parser
that referenced
this pull request
Jan 4, 2019
Content-Length with line folding was accepted with invalid input. Treat obsolete line folding as space and continue parsing Fixes: nodejs#456 PR-URL: nodejs#458 Reviewed-By: Ben Noordhuis <[email protected]>
|
Is this a security issue? Does it need a CVE? Does it need releasing onto Node.js LTS branches? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the issue: #456