Skip to content
This repository has been archived by the owner on Jul 6, 2018. It is now read-only.

Error in socketOnTimeout #179

Closed
sebdeckers opened this issue Jul 13, 2017 · 3 comments
Closed

Error in socketOnTimeout #179

sebdeckers opened this issue Jul 13, 2017 · 3 comments

Comments

@sebdeckers
Copy link
Contributor

  • Version: 9.0.0pre 1eec6da
  • Platform: macOS
  • Subsystem: http2

I'm getting some real-world traffic on my server and it occasionally throws these uncaught errors. Seems to be related to the socket timeout.

internal/http2/core.js:1992
    this[kSession].shutdown(
                  ^

TypeError: Cannot read property 'shutdown' of undefined
    at TLSSocket.socketOnTimeout (internal/http2/core.js:1992:19)
    at emitNone (events.js:110:20)
    at TLSSocket.emit (events.js:207:7)
    at TLSSocket.Socket._onTimeout (net.js:402:8)
    at ontimeout (timers.js:488:11)
    at tryOnTimeout (timers.js:323:5)
    at Timer.listOnTimeout (timers.js:283:5)
@jasnell
Copy link
Member

jasnell commented Jul 14, 2017

Looks like destroy is happening before the timeout, we need to make sure that destroying clears the timeout to avoid the issue here.

@jasnell
Copy link
Member

jasnell commented Jul 19, 2017

Think I have this one and in the process fixed another issue.

jasnell added a commit that referenced this issue Jul 19, 2017
Fixes: #179

Was fixing issue #179 and encountered a segault that was
happening somewhat randomly on session destruction. Both
should be fixed
@sebdeckers
Copy link
Contributor Author

Great, I'll give it a try! Will reopen if I find any issues. Thanks for this.

Been meaning to write that compat documentation but haven't had much time this week because we bought a new place. Learning a lot about plastering walls though. 🤷‍♂️

jasnell added a commit that referenced this issue Jul 22, 2017
Fixes: #179

Was fixing issue #179 and encountered a segault that was
happening somewhat randomly on session destruction. Both
should be fixed
jasnell added a commit that referenced this issue Aug 3, 2017
Fixes: #179

Was fixing issue #179 and encountered a segault that was
happening somewhat randomly on session destruction. Both
should be fixed
jasnell added a commit to nodejs/node that referenced this issue Aug 4, 2017
Fixes: nodejs/http2#179

Was fixing issue #179 and encountered a segault that was
happening somewhat randomly on session destruction. Both
should be fixed

PR-URL: #14239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
jasnell added a commit to jasnell/node that referenced this issue Aug 13, 2017
Fixes: nodejs/http2#179

Was fixing issue nodejs#179 and encountered a segault that was
happening somewhat randomly on session destruction. Both
should be fixed

PR-URL: nodejs#14239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
addaleax pushed a commit to nodejs/node that referenced this issue Aug 14, 2017
Fixes: nodejs/http2#179

Was fixing issue #179 and encountered a segault that was
happening somewhat randomly on session destruction. Both
should be fixed

Backport-PR-URL: #14813
Backport-Reviewed-By: Anna Henningsen <[email protected]>
Backport-Reviewed-By: Timothy Gu <[email protected]>

PR-URL: #14239
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants