Skip to content
This repository has been archived by the owner on Jul 6, 2018. It is now read-only.

http2: additional refinement of stream/session #138

Closed
wants to merge 4 commits into from
Closed

http2: additional refinement of stream/session #138

wants to merge 4 commits into from

Commits on May 31, 2017

  1. http2: remove test-async-wrap-check-providers (Squash) 

    Following rebase, test file is no longer needed

also: TEMPORARY... allow the test-async-wrap-getasyncid to pass
by skipping the http2 specific bits
    @jasnell
    jasnell committed May 31, 2017
    Configuration menu
    Copy the full SHA
    1dc30e5 View commit details
    Browse the repository at this point in the history

  2. http2: fixup SessionSendBuffer impl (Squash) 

    The WriteWrap impl details changed slightly. Fixup
the cleanup logic for SessionSendBuffer class in
node_http2.h accordingly.
    @jasnell
    jasnell committed May 31, 2017
    Configuration menu
    Copy the full SHA
    ee243e4 View commit details
    Browse the repository at this point in the history

  3. http2: significant internal refactoring 

    * tighten up the Http2Stream/Http2Session lifecycle, destroy, and
  error handling. Some simplification, and more new tests

* Eliminate queuing of internal callbacks. Queuing these to fire on
  the next event loop tick was throwing off timing. Now the js callbacks
  are called directly as they happen. This will require a bit more
  finesse on the javascript side (to ensure appropiate timing of
  destroy/shutdown actions) but that is handled from within the core
  api impl so users should not be affected.

* fix debug output with nghttp2
    @jasnell
    jasnell committed May 31, 2017
    Configuration menu
    Copy the full SHA
    d33abaf View commit details
    Browse the repository at this point in the history

  4. http2: add configured debug statements 

    Using `./configure --debug-http2` will enable verbose debug
statements from node.js,

Using `./configure --debug-nghttp2` will enable verbose debug
statements from nghttp2.

The two can be used together
    @jasnell
    jasnell committed May 31, 2017
    Configuration menu
    Copy the full SHA
    d6d0dff View commit details
    Browse the repository at this point in the history