api: introduce llhttp_set_lenient_keep_alive
#94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indutny
force-pushed
the
feature/lenient-keep-alive
branch
from
45db7b1
to
5ae6adb
Compare
|
cc @nodejs/http a review would be appreciated. |
Extra request/response after `Connection: close` should be either discarded (in loose mode), or produce error (in strict mode). However, to support legacy client we introduce: * `llhttp_set_lenient_keep_alive` API call to process the extra request normally. Note that it opens the server to potential cache poisoning attacks and is dangerous to enable in the most of situations.
indutny
force-pushed
the
feature/lenient-keep-alive
branch
from
5ae6adb
to
6467a62
Compare
|
Had to force push because of the duplicate test 🤦 Thanks @mcollina for review. Will land once CI is clear. |
indutny
added a commit
that referenced
this pull request
Mar 27, 2021
Extra request/response after `Connection: close` should be either discarded (in loose mode), or produce error (in strict mode). However, to support legacy client we introduce: * `llhttp_set_lenient_keep_alive` API call to process the extra request normally. Note that it opens the server to potential cache poisoning attacks and is dangerous to enable in the most of situations. PR-URL: #94 Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extra request/response after
Connection: closeshould be eitherdiscarded (in loose mode), or produce error (in strict mode). However,
to support legacy client we introduce:
llhttp_set_lenient_keep_aliveAPI call to process the extra request normally. Note that it opens the
server to potential cache poisoning attacks and is dangerous to
enable in the most of situations.