-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAN 1.6 #238
Conversation
3a4585c
to
c1b675c
Compare
This will not work with node webkit, as they have updated v8, but not indicated it in any detectable way as far as I can see. Too bad. |
@rogerwang is there someone in particular we should pull in for this? nw.js could lose solid native addon support if we can't find a resolution to this. |
#226 is related for slightly different reasons |
I'll help to fix this. What do I need to do in nw.js? defining NODE_MODULE_VERSION to some value? |
@kkoopa do we a good have a recommendation here? @rogerwang if your ABI is the same as some io.js or node release then match the |
It should be the same as io.js. I'll update the io.js in nw.js, so it will be 42. Currently it's some old version (1.0.0). |
Ah, that would of course explain the mismatch. io.js only bumped |
be1e88f
to
6b55ed6
Compare
NW.js v0.12.0-alpha3 was released ≈8 hours ago. Its inner Chromium is updated to 41 beta (41.0.2272.32) and io.js is updated to v1.2.0. Does that mean nan support? |
I guess so. On February 13, 2015 5:46:14 PM EET, Mithgol [email protected] wrote:
|
NanNewContextHandle
in favor ofNanNew<Context>
.