Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build breakage with Node.js 10.0.0-10.9.0. #833

Merged
merged 1 commit into from
Dec 18, 2018
Merged

Fix build breakage with Node.js 10.0.0-10.9.0. #833

merged 1 commit into from
Dec 18, 2018

Commits on Dec 18, 2018

  1. Fix build breakage with Node.js 10.0.0-10.9.0. 

    The five argument WriteUtf8() method was introduced in Node.js v10.0.0,
it doesn't exist in older 10.x releases.

Use the four argument overload and a bunch of pragmas to silence the
compiler warnings.

Fixes: #832
Refs: #825
    @bnoordhuis
    bnoordhuis committed Dec 18, 2018
    Configuration menu
    Copy the full SHA
    17ffec1 View commit details
    Browse the repository at this point in the history