Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify binaries while creating release blog post #186

Closed
wants to merge 1 commit into from

Conversation

phillipj
Copy link
Member

At the moment of creating the release blog post, there's a chance not all binaries has been uploaded to nodejs.org/dist/ yet.

In these circumstances those specific binaries should have "Coming soon" rather than the actual download URL as those URLs would fail with a 404 page anyway.

This change enables that behaviour by verifying all the binaries about to be included in the blog post, by doing a HEAD request against each of the URLs where they're supposed to be located.

Refs #156

cc @nodejs/release

At the moment of creating the release blog post, there's a
chance not all binaries has been uploaded to nodejs.org/dist/ yet.

In these circumstances those specific binaries should have
"Coming soon" rather than the actual download URL as those
URLs would fail with a 404 page anyway.

This change enables that behaviour by verifying all the binaries
about to be included in the blog post, by doing a HEAD request against
each of the URLs where they're supposed to be located.
@rvagg rvagg mentioned this pull request Sep 23, 2015
@rvagg
Copy link
Member

rvagg commented Sep 23, 2015

Merged and I used this for v4.1.1. I had to fix the ARMv7 link to make it armv7l (missing l) but it worked aside from that.

I did a couple of extra things for this release that are not covered by the script:

  • removed the ## header of the release, I don't think we need it given that all of that information is contained in the metadata of the post
  • added author: Rod Vagg, it would be nice to automate this, we could either use the GitHub API or just web scrape to look up the release tag (v4.1.1) and find the commit for that tag and look at the author behind the tag (you can get the git.name which is probably the best one to use here). Another alternative is to scrape the README @ https://github.com/nodejs/node/blob/v4.1.1/README.md#current-project-team-members and look at the username / name mapping and match that against the username included in the CHANGELOG.md ## heading. Or .. just hardwire a mapping in the script here might be easiest!
  • added a bit of summary text at the top, but this doesn't need to be automated and often won't be there

great work on this though!

@rvagg rvagg closed this Sep 23, 2015
@phillipj phillipj deleted the verify-binaries branch September 23, 2015 07:20
@phillipj
Copy link
Member Author

Thanks! I'll add two tasks for the improvements you mentioned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants